Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: align image version with version file #23

Conversation

c3y1huang
Copy link
Contributor

Which issue(s) this PR fixes:

Issue None

What this PR does / why we need it:

Align the default image version used in the command line option with the version specified in the version file.

Special notes for your reviewer:

None

Additional documentation or context

None

@c3y1huang c3y1huang self-assigned this Jul 11, 2024
@c3y1huang c3y1huang marked this pull request as ready for review July 11, 2024 07:41
@c3y1huang c3y1huang requested a review from derekbit July 11, 2024 07:41
dapper/version Outdated Show resolved Hide resolved
@c3y1huang c3y1huang force-pushed the feat-dynamic-image-version-using-version-file branch from 9676aba to 5ee12b9 Compare July 11, 2024 07:53
@c3y1huang c3y1huang requested a review from derekbit July 11, 2024 07:53
Copy link
Member

@derekbit derekbit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@derekbit derekbit merged commit 0d92553 into longhorn:master Jul 11, 2024
3 checks passed
@c3y1huang c3y1huang deleted the feat-dynamic-image-version-using-version-file branch July 11, 2024 08:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants