Support setting spdk_tgt log level and flags #402
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Feb 18, 2024
derekbit
force-pushed
the
issue-7939
branch
4 times, most recently
from
8f0f34c to
86c183c
Compare
|
This pull request is now in conflict. Could you fix it @derekbit? 🙏 |
Longhorn 7939 Signed-off-by: Derek Su <[email protected]>
Longhorn 7939 Signed-off-by: Derek Su <[email protected]>
Longhorn 7939 Signed-off-by: Derek Su <[email protected]>
Longhorn 7939 Signed-off-by: Derek Su <[email protected]>
Longhorn 7939 Signed-off-by: Derek Su <[email protected]>
Bump InstanceManagerAPIVersion to 6 because of the introduction of log methods. Longohrn 7939 Signed-off-by: Derek Su <[email protected]>
Longhorn 7939 Signed-off-by: Derek Su <[email protected]>
innobead
approved these changes
Mar 7, 2024
innobead
reviewed
Mar 7, 2024
| @@ -336,7 +336,7 @@ func (p *Proxy) RemountReadOnlyVolume(ctx context.Context, req *rpc.RemountVolum | |||
| "remount,rw", | |||
| mp.Path, | |||
| } | |||
| if _, err := nsexec.Execute("mount", opts, lhtypes.ExecuteDefaultTimeout); err != nil { | |||
| if _, err := nsexec.Execute(nil, "mount", opts, lhtypes.ExecuteDefaultTimeout); err != nil { | |||
There was a problem hiding this comment.
@ChanYiLin @derekbit already fixed the issue here.
innobead
reviewed
Mar 7, 2024
| @@ -2,7 +2,7 @@ package meta | |||
|
|
|||
| const ( | |||
| // InstanceManagerAPIVersion is used for compatibility check for longhorn-manager | |||
| InstanceManagerAPIVersion = 5 | |||
| InstanceManagerAPIVersion = 6 | |||
There was a problem hiding this comment.
Although we add new methods to InstanceService gRPC interface, it does not really need to bump InstanceManagerAPIVersion here, because:
- When an old client calls any existing methods in a new instance manager w/ these new methods, everything should work correctly because of backward compatibility in gRPC.
- When a new client calls any new method in an old instance manager, even though the method does not exist, the call will just do nothing, because of forward compatibility.
We Need to review the current traditional version flag way to control how new/old longhorn manager communicates with new/old instance manager, but rather rely on gRPC capabilities.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue(s) this PR fixes:
Issue longhorn/longhorn#7939
What this PR does / why we need it:
Special notes for your reviewer:
Additional documentation or context
Deps on longhorn/longhorn-spdk-engine#108