Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(auto-balance): disk in pressure #2547

Merged
merged 9 commits into from
Jul 9, 2024

Conversation

c3y1huang
Copy link
Contributor

Which issue(s) this PR fixes:

Issue longhorn/longhorn#4105

What this PR does / why we need it:

  • Introduces new replica-auto-balance-disk-pressure-percentage setting.
  • Implement local file sync for newly added replicas.

Special notes for your reviewer:

None

Additional documentation or context

None

@c3y1huang c3y1huang self-assigned this Feb 2, 2024
@c3y1huang c3y1huang force-pushed the feat-auto-balance-node-disks branch from 8a21f1f to 7b52574 Compare February 2, 2024 07:35
go.mod Outdated Show resolved Hide resolved
go.mod Outdated Show resolved Hide resolved
@c3y1huang c3y1huang marked this pull request as ready for review February 5, 2024 02:36
@c3y1huang c3y1huang requested a review from a team as a code owner February 5, 2024 02:36
Copy link

mergify bot commented Feb 7, 2024

This pull request is now in conflicts. Could you fix it @c3y1huang? 🙏

Copy link

mergify bot commented Apr 18, 2024

This pull request is now in conflict. Could you fix it @c3y1huang? 🙏

1 similar comment
Copy link

mergify bot commented Apr 24, 2024

This pull request is now in conflict. Could you fix it @c3y1huang? 🙏

@c3y1huang c3y1huang force-pushed the feat-auto-balance-node-disks branch 2 times, most recently from 67f4298 to 7471d5a Compare June 21, 2024 00:16
Copy link

mergify bot commented Jun 21, 2024

This pull request is now in conflict. Could you fix it @c3y1huang? 🙏

@c3y1huang c3y1huang force-pushed the feat-auto-balance-node-disks branch 8 times, most recently from f6920e2 to c1fd443 Compare June 21, 2024 07:05
Copy link

mergify bot commented Jun 22, 2024

This pull request is now in conflict. Could you fix it @c3y1huang? 🙏

@c3y1huang c3y1huang force-pushed the feat-auto-balance-node-disks branch 5 times, most recently from 32628a6 to 3856755 Compare July 2, 2024 01:39
@c3y1huang c3y1huang requested a review from derekbit July 5, 2024 04:01
derekbit
derekbit previously approved these changes Jul 5, 2024
Copy link
Member

@derekbit derekbit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@derekbit
Copy link
Member

derekbit commented Jul 5, 2024

If @shuo-wu and @innobead has no other concerns, we can merge it.

Copy link

mergify bot commented Jul 6, 2024

This pull request is now in conflict. Could you fix it @c3y1huang? 🙏

@derekbit
Copy link
Member

derekbit commented Jul 8, 2024

We can merge it after the conflicts are resolved.

…e" setting

longhorn/longhorn-4105

Signed-off-by: Chin-Ya Huang <[email protected]>
@c3y1huang c3y1huang force-pushed the feat-auto-balance-node-disks branch from e135ba8 to 9fc4868 Compare July 9, 2024 00:37
@c3y1huang c3y1huang requested a review from derekbit July 9, 2024 00:55
datastore/longhorn.go Outdated Show resolved Hide resolved
c3y1huang added 6 commits July 9, 2024 09:11
…centage" setting

longhorn/longhorn-4105

Signed-off-by: Chin-Ya Huang <[email protected]>
longhorn/longhorn-4105

Signed-off-by: Chin-Ya Huang <[email protected]>
longhorn/longhorn-4105

Signed-off-by: Chin-Ya Huang <[email protected]>
…etting

longhorn/longhorn-4105

Signed-off-by: Chin-Ya Huang <[email protected]>
Signed-off-by: Chin-Ya Huang <[email protected]>
@c3y1huang c3y1huang force-pushed the feat-auto-balance-node-disks branch from 9fc4868 to 789aad8 Compare July 9, 2024 01:11
@c3y1huang c3y1huang requested a review from derekbit July 9, 2024 01:12
datastore/longhorn.go Outdated Show resolved Hide resolved
@c3y1huang c3y1huang force-pushed the feat-auto-balance-node-disks branch 3 times, most recently from 11ddd16 to 45ba44d Compare July 9, 2024 02:01
@c3y1huang c3y1huang force-pushed the feat-auto-balance-node-disks branch from 45ba44d to 3518ab5 Compare July 9, 2024 02:22
@c3y1huang c3y1huang requested a review from derekbit July 9, 2024 03:05
@derekbit derekbit merged commit 280c105 into longhorn:master Jul 9, 2024
7 checks passed
@c3y1huang c3y1huang deleted the feat-auto-balance-node-disks branch July 9, 2024 03:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants