Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: change to use GitHub actions #102

Merged
merged 2 commits into from
Jul 2, 2024
Merged

Conversation

FrankYang0529
Copy link
Contributor

Which issue(s) this PR fixes:

longhorn/longhorn#8039

What this PR does / why we need it:

Special notes for your reviewer:

Additional documentation or context

jobs:
build:
name: Build binaries
runs-on: ubuntu-latest
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just curious, do we have other options?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@FrankYang0529
Copy link
Contributor Author

Hi @derekbit, it looks like test failed because I added error check to avoid lint issue. Can we assert err is nil here?

err := rest.TestServer(context.Background(), port, dst, timeout)
assert.Nil(t, err)

@FrankYang0529
Copy link
Contributor Author

Hi @derekbit, it looks like test failed because I added error check to avoid lint issue. Can we assert err is nil here?

err := rest.TestServer(context.Background(), port, dst, timeout)
assert.Nil(t, err)

It looks like server returns http: Server closed when server is closed. I update the test case.

@FrankYang0529
Copy link
Contributor Author

Hi @derekbit, I tried to remove error check, but there still has data race condition. May you take a look when you have time? Thank you.

https://github.com/longhorn/sparse-tools/actions/runs/8888699426/job/24405917283?pr=102

@shuo-wu
Copy link
Contributor

shuo-wu commented Jun 18, 2024

I am fine with merging this then using another ticket to track the data race

@derekbit derekbit merged commit 926fecc into longhorn:master Jul 2, 2024
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants