Add custom 2FA based on default codeigniter4/shield email 2FA #416
Conversation
There was a problem hiding this comment.
Thanks for this! Definitely a missed piece.
I see you're extending the action from Shieid - that's perfect. Because of that please delete an methods in this class that don' specifically need to be here for theming purposes.
Actually, IIRC the Actions use a Themeable trait that only provides $this->view() method. Would it be possible to ONLY override that method in this action to make use of the theme? Then all of the other methods wouldn't have to be duplicated which would make it safer then us having to constantly update those files when the logic changes?
kgrruz
force-pushed
the
add-2FA-shield-action
branch
from
862bdc0 to
30dbcc0
Compare
|
Done. Thank you for the explanation. If any other changes are needed, just tell me. |
kgrruz
force-pushed
the
add-2FA-shield-action
branch
2 times, most recently
from
e2cc9f9 to
a86a261
Compare
…o make use of the themes.
kgrruz
force-pushed
the
add-2FA-shield-action
branch
from
a86a261 to
5421328
Compare
|
From what I see @kgrruz , is the getIdentity method a copy of the original shield method? Perhaps it should also be removed? [I was wrong here :) ] Also, customized views should be added to src/Views/Auth and those views have to replace the default ones in the configuration file. |
|
Starting off with your extended class, I have added a complete implementation at #501 |
|
Adapting your code in #501 I made a complete solution. So I am closing this PR. Thanks for contribution. |
Add custom 2FA based on default codeigniter4/shield email 2FA. Just to make use of the themes.