Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log viewer fix #472

Merged
merged 2 commits into from
Dec 30, 2024
Merged

Log viewer fix #472

merged 2 commits into from
Dec 30, 2024

Conversation

dgvirtual
Copy link
Collaborator

Log viewer could be broken because of site_date() function omitting default values. Some minor improvements added.

Copy link
Owner

@lonnieezell lonnieezell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please rebase this branch off of the latest so the pagination changes are not a part of this PR.

In the future, please keep PRs off of develop so they don't include changes that are in other PRs.

@dgvirtual
Copy link
Collaborator Author

Rebased, pushed, I hope I got it right this time :)

Copy link
Owner

@lonnieezell lonnieezell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks!

@lonnieezell lonnieezell merged commit 553403c into lonnieezell:develop Dec 30, 2024
6 of 7 checks passed
@dgvirtual dgvirtual deleted the log_viewer_fix branch January 2, 2025 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants