Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dublicate csfixer and make rector usable #477

Merged
merged 5 commits into from
Dec 30, 2024

Conversation

dgvirtual
Copy link
Collaborator

I would like to see less failing tests on PRs... So I suggest fixing the code inspection side of the project. I am quite new at github actions so please take a careful look at this PR...

The changes included:

  1. Since there are two cs-fixer files, remove the one that marks all PRs as invalid, make the system and github actions use the less-demanding cs-fixer.
  2. Make the rector usable (comment out rules not found in the current version)
  3. Fix composer command paths for code quality inspection and fixing

fix for #471

Copy link
Owner

@lonnieezell lonnieezell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this looks like the proper solution. Thanks for catching the missing rector classes. I wonder what they changed those too.. but that's a problem for another day. :)

@lonnieezell lonnieezell merged commit c997614 into lonnieezell:develop Dec 30, 2024
7 checks passed
@dgvirtual dgvirtual deleted the remove_dublicate_csfixer branch January 2, 2025 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants