sx127x: Use integer math for freq / pll_step calculations #285
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
plaes
requested review from
lucasgranberg,
CBJamo,
Dirbaio and
lthiery
as code owners
|
Great work, I love the tests. Do you know how far off these calculations are for 0.1Mhz steps? What is an acceptable error? I would love to see some calculations on this. I can try to do some tonight. |
|
With current formula the conversion is same for each full and half megahertz step: And even if I add additional |
lucasgranberg
previously approved these changes
Sep 3, 2024
lthiery
reviewed
Sep 3, 2024
lthiery
previously approved these changes
Sep 3, 2024
No need to use floats, integer freq -> pll_step conversion is good enough when dealing with full megahertz calculations.
plaes
force-pushed
the
sx127x-freq-floats
branch
from
fc59f3d to
fc5c8c7
Compare
lthiery
approved these changes
Sep 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No need to use floats, integer freq -> pll_step conversion is good enough when dealing with full megahertz calculations.
This switches frequency <-> pll step calculations to integer math in sx127x driver. (Issue #282)
See also:
Lora-net/SWL2001#87