FIXES TYPO IN OccurrenceConstraintViolation

[Sharath1804]

Proposed changes

Currently when there are errors in ocpp message central system responds to the chargers with OccurrenceConstraintViolation error code for example, a missing value for a measurand in the MeterValues.Req.

However, there is an extra "r" in the error code and is a deviation from the OCPP spec. This also causes few of the chargers to indefinitely send the same faulty OCPP message until its cache gets exhausted and needs to be fixed.
Error code from the documentation - https://downloads.regulations.gov/FHWA-2022-0008-0403/attachment_6.pdf

As part of this change the type is fixed and the status has been changed from OccurrenceConstraintViolation to OccurenceConstraintViolation.

NOTE: OccurrenceConstraintViolation is a typo in both OCPP 1.6 and OCPP 2.0.1. The right error code for both the versions is OccurenceConstraintViolation.

Types of changes

• Bugfix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• Documentation Update (if none of the other choices apply)

Checklist

• I have read the CONTRIBUTING doc
• I have signed the CLA
• Lint and unit tests pass locally with my changes
• I have added tests that prove my fix is effective or that my feature works
• I have added necessary documentation (if appropriate)
• Any dependent changes have been merged and published in downstream modules

Further comments

NA

[lorenzodonini]

Thanks for spotting. This is similar to #211.

Basically:

• v1.6 should keep the version with the typo OccurenceConstraintViolation
• v2 should use the correct version without the typo OccurrenceConstraintViolation

To not break the v2 implementation, the same approach as in the linked PR is needed. Could you adjust the changes accordingly? Otherwise I will take care of it

[Sharath1804]

Thanks for spotting. This is similar to #211.

Basically:

• v1.6 should keep the version with the typo OccurenceConstraintViolation
• v2 should use the correct version without the typo OccurrenceConstraintViolation

To not break the v2 implementation, the same approach as in the linked PR is needed. Could you adjust the changes accordingly? Otherwise I will take care of it

Hello,

As per #211 we have two different error codes for OCPP 1.6 and OCPP 2.0.1 i.e., FormationViolation vs FormatViolation respectively. However OccurenceConstraintViolation holds good for both OCPP 1.6 and OCPP 2.0.1.

Please find the attached screen grabs from OCPP 1.6 and OCPP 2.0.1 spec indicating the same value for both the OCPP versions.

[lorenzodonini]

@Sharath1804 The first document you linked is not in sync with the actual ocpp-j spec (it's a separate document, which is where the RPC error codes are defined). I blame it on a typo on that specific section you quoted.

Here's the actual spec updated to its latest version. I also double-checked with an older version I had lying around and the value is unchanged since the inception of v2.

In other words: my previous statement holds and we have to support two different constants, one for v1.6 and one for v2.