Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: FlatDependencyTree type definition #8

Merged
merged 1 commit into from
Oct 26, 2024

Conversation

marcvincenti
Copy link
Contributor

@marcvincenti marcvincenti commented Oct 25, 2024

Hi,
I noticed a regression in the external dependencies type introduced by #6.

Here is a minimal repro

const provide = createProvider({
  injectables: {
    foo: ({ service }: { service: number }) => service,
    service: ({ nonTypedDep }) => nonTypedDep,
  },
  api: ['foo'],
});
provide()

This behavior propagates to other external dependencies which won't be required.

@marcvincenti marcvincenti marked this pull request as ready for review October 25, 2024 15:47
Copy link
Owner

@lorenzofox3 lorenzofox3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Marc.

It fixes the regression indeed, yet I don't understand why 😅

@lorenzofox3 lorenzofox3 merged commit b4d2d52 into lorenzofox3:main Oct 26, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants