Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update upload artifact and add option for extra repositories #143

Merged
merged 8 commits into from
Sep 23, 2024

Conversation

seabbs
Copy link
Contributor

@seabbs seabbs commented Sep 17, 2024

As the title, this PR updates the version of upload artifacts which was throwing a depreciation error for me.

I have also added a pass-through of the extra_repositories option for setup-r as our use case needs this in order to install our dependencies (I can split this off into another PR if desired).

I have this running here from my fork and it looks like everything is now working as expected: https://github.com/epinowcast/primarycensoreddist/actions/runs/10906920699?pr=79

The non-forked version is failing here with the depreciation note I mentioned: https://github.com/epinowcast/epinowcast/actions/runs/10839748687?pr=528

Thanks a lot for keeping this ticking over. We find it very useful for a lot of our work.

@lorenzwalthert
Copy link
Owner

Thanks, any objections @assignUser and @plietar?

@seabbs
Copy link
Contributor Author

seabbs commented Sep 17, 2024

To get this fully working I had to switch out to use download-artifact in the comment action. Can see this working here: epinowcast/primarycensored#80

Copy link
Collaborator

@assignUser assignUser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great to be able to remove the custom script 👍

actions/comment/action.yaml Outdated Show resolved Hide resolved
@seabbs
Copy link
Contributor Author

seabbs commented Sep 23, 2024

I’ve updated to include the changes from @sbfnk in #144

@lorenzwalthert
Copy link
Owner

@seabbs the PR is approved, you can merge it ;D

@seabbs
Copy link
Contributor Author

seabbs commented Sep 23, 2024

I see only those with write access to this repository can merge this PR.

@lorenzwalthert lorenzwalthert merged commit 289cfc7 into lorenzwalthert:main Sep 23, 2024
6 checks passed
@lorenzwalthert
Copy link
Owner

Oh ok 😄.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants