-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update upload artifact and add option for extra repositories #143
Conversation
Thanks, any objections @assignUser and @plietar? |
To get this fully working I had to switch out to use |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great to be able to remove the custom script 👍
@seabbs the PR is approved, you can merge it ;D |
I see only those with write access to this repository can merge this PR. |
Oh ok 😄. |
As the title, this PR updates the version of upload artifacts which was throwing a depreciation error for me.
I have also added a pass-through of the
extra_repositories
option forsetup-r
as our use case needs this in order to install our dependencies (I can split this off into another PR if desired).I have this running here from my fork and it looks like everything is now working as expected: https://github.com/epinowcast/primarycensoreddist/actions/runs/10906920699?pr=79
The non-forked version is failing here with the depreciation note I mentioned: https://github.com/epinowcast/epinowcast/actions/runs/10839748687?pr=528
Thanks a lot for keeping this ticking over. We find it very useful for a lot of our work.