Speed Optimizations #89
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sidjha1
commented
Jan 26, 2025
| @@ -286,7 +310,7 @@ def run_sem_sim_join(l1: pd.Series, l2: pd.Series, col1_label: str, col2_label: | |||
| l2_df = l2.to_frame(name=col2_label) | |||
| l2_df = l2_df.sem_index(col2_label, f"{col2_label}_index") | |||
|
|
|||
| K = len(l2) * len(l1) | |||
| K = len(l2) | |||
There was a problem hiding this comment.
@melissa-pan can you verify this change? I don't think K should be multiplied by len(l1) since we are only searching an index on l2
There was a problem hiding this comment.
as per discussion, k should be l2. thanks!
liana313
approved these changes
Jan 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pydanticwithdataclassto save on validation timesKinrun_sem_sim_joinsem_joinLM::__call__