refactor(lox-orbits): switch loop order for visibility

lox-space · Feb 10, 2025 · d5cf084 · d5cf084
1 parent f0ca53e
commit d5cf084
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 9 deletions.
diff --git a/crates/lox-orbits/src/python.rs b/crates/lox-orbits/src/python.rs
@@ -815,16 +815,16 @@ pub fn visibility_all(
     let spacecraft = &spacecraft.get().0;
     let ephemeris = &ephemeris.get().0;
     Ok(py.allow_threads(|| {
-        ground_stations.iter().fold(
-            HashMap::with_capacity(ground_stations.len()),
-            |mut passes, (gs_name, (gs, mask))| {
+        spacecraft.iter().fold(
+            HashMap::with_capacity(spacecraft.len()),
+            |mut passes, (sc_name, sc)| {
                 passes.insert(
-                    gs_name.clone(),
-                    spacecraft
+                    sc_name.clone(),
+                    ground_stations
                         .par_iter()
-                        .fold(HashMap::new, |mut passes, (sc_name, sc)| {
+                        .fold(HashMap::new, |mut passes, (gs_name, (gs, mask))| {
                             passes.insert(
-                                sc_name.clone(),
+                                gs_name.clone(),
                                 visibility_combined(
                                     &times, &gs.0, &mask.0, &bodies, sc, ephemeris, provider,
                                 )

diff --git a/crates/lox-space/tests/test_benchmarks.py b/crates/lox-space/tests/test_benchmarks.py
@@ -23,6 +23,6 @@ def ensemble(oneweb):
 @pytest.mark.benchmark()
 def test_visibility_benchmark(estrack, ensemble, oneweb, provider, times, ephemeris):
     passes = lox.visibility_all(times, estrack, ensemble, ephemeris, provider=provider)
-    assert len(passes) == len(estrack)
+    assert len(passes) == len(oneweb)
     for sc_passes in passes.values():
-        assert len(sc_passes) == len(oneweb)
+        assert len(sc_passes) == len(estrack)