Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for ddd KVN dates #206

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

matzipan
Copy link
Collaborator

@matzipan matzipan commented Feb 10, 2025

I would have preferred to import lox-time and convert with from_day_of_year, but lox-time already depends on lox-io so it would be a circular dependency.

A more involved solution would be to break up lox-io on smaller crates and only have the NDM stuff depend on lox-time.

Open to suggestions

Closes #120

1.5

Copy link

codecov bot commented Feb 10, 2025

Codecov Report

Attention: Patch coverage is 91.17647% with 3 lines in your changes missing coverage. Please review.

Project coverage is 70.90%. Comparing base (2d1e3f2) to head (003a516).

Files with missing lines Patch % Lines
crates/lox-io/src/ndm/kvn/parser.rs 91.17% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #206      +/-   ##
==========================================
- Coverage   70.91%   70.90%   -0.01%     
==========================================
  Files          82       82              
  Lines       21801    21805       +4     
==========================================
+ Hits        15460    15461       +1     
- Misses       6341     6344       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

codspeed-hq bot commented Feb 10, 2025

CodSpeed Performance Report

Merging #206 will not alter performance

Comparing az/add-support-for-ddd-format (f55819e) with main (ba514f3)

Summary

✅ 1 untouched benchmarks

@matzipan matzipan force-pushed the az/add-support-for-ddd-format branch from 1a7bc57 to 003a516 Compare February 10, 2025 23:04
@matzipan matzipan force-pushed the az/add-support-for-ddd-format branch from 003a516 to 8a41507 Compare February 12, 2025 22:03
@matzipan matzipan force-pushed the az/add-support-for-ddd-format branch from 8a41507 to f55819e Compare February 12, 2025 22:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for ddd day format and update docs
2 participants