Moving Interview Questions Config to Own Page (#187)

* moving question config to new page * fixing weird scrolling * scrolling to question on question add * Adding delete confirmation dialog * removing old dialog * moving dnd package in client package json
ls1intum · Feb 17, 2025 · 93877bb · 93877bb
1 parent 5d9d500
commit 93877bb
Show file tree

Hide file tree

Showing 8 changed files with 220 additions and 211 deletions.
diff --git a/clients/core/package.json b/clients/core/package.json
@@ -12,7 +12,6 @@
     },
     "dependencies": {
         "@dagrejs/dagre": "^1.1.4",
-        "@hello-pangea/dnd": "^17.0.0",
         "@xyflow/react": "^12.3.6",
         "date-fns-tz": "^3.2.0",
         "external-remotes-plugin": "^1.0.0",

diff --git a/clients/interview_component/routes/index.tsx b/clients/interview_component/routes/index.tsx
@@ -4,6 +4,7 @@ import { Role } from '@tumaet/prompt-shared-state'
 import { InterviewDataShell } from '../src/interview/pages/InterviewDataShell'
 import { ProfileDetailPage } from '../src/interview/pages/ProfileDetail/ProfileDetailPage'
 import { MailingPage } from '../src/interview/pages/Mailing/MailingPage'
+import { QuestionConfiguration } from '../src/interview/pages/QuestionConfiguration/QuestionConfiguration'
 
 const interviewRoutes: ExtendedRouteObject[] = [
   {
@@ -24,6 +25,15 @@ const interviewRoutes: ExtendedRouteObject[] = [
     ),
     requiredPermissions: [Role.PROMPT_ADMIN, Role.COURSE_LECTURER],
   },
+  {
+    path: '/question-configuration',
+    element: (
+      <InterviewDataShell>
+        <QuestionConfiguration />
+      </InterviewDataShell>
+    ),
+    requiredPermissions: [Role.PROMPT_ADMIN, Role.COURSE_LECTURER],
+  },
   {
     path: '/mailing',
     element: (

diff --git a/clients/interview_component/sidebar/index.tsx b/clients/interview_component/sidebar/index.tsx
@@ -8,6 +8,11 @@ const interviewSidebarItems: SidebarMenuItemProps = {
   goToPath: '',
   requiredPermissions: [Role.PROMPT_ADMIN, Role.COURSE_LECTURER],
   subitems: [
+    {
+      title: 'Question Config',
+      goToPath: '/question-configuration',
+      requiredPermissions: [Role.PROMPT_ADMIN, Role.COURSE_LECTURER],
+    },
     {
       title: 'Mailing',
       goToPath: '/mailing',

diff --git a/clients/interview_component/src/interview/components/InterviewQuestionsDialog.tsx b/clients/interview_component/src/interview/components/InterviewQuestionsDialog.tsx
diff --git a/clients/interview_component/src/interview/pages/Overview/OverviewPage.tsx b/clients/interview_component/src/interview/pages/Overview/OverviewPage.tsx
@@ -6,7 +6,6 @@ import { useLocation, useNavigate } from 'react-router-dom'
 import { useScreenSize } from '@/hooks/useScreenSize'
 import { useState } from 'react'
 import { SortDropdownMenu } from '../../components/SortDropdownMenu'
-import { InterviewQuestionsDialog } from '../../components/InterviewQuestionsDialog'
 import { InterviewTimesDialog } from '../../components/InterviewTimesDialog'
 import { useSorting } from '../../hooks/useSorting'
 
@@ -25,7 +24,6 @@ export const OverviewPage = (): JSX.Element => {
         <div className='flex space-x-2'>
           <SortDropdownMenu sortBy={sortBy} setSortBy={setSortBy} />
           <InterviewTimesDialog />
-          <InterviewQuestionsDialog />
         </div>
       </div>
       <div