Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mailing settings improvements #153

Merged
merged 3 commits into from
Feb 14, 2025
Merged

Mailing settings improvements #153

merged 3 commits into from
Feb 14, 2025

Conversation

niclasheun
Copy link
Contributor

This addressed the issue that the mailing settings were disabled and not understandable for the user why.
Now each disabled button has an explanatory tooltip and a little warning is displayed if any mail setting is disabled.

image

@niclasheun niclasheun requested a review from Mtze February 9, 2025 16:07
@niclasheun niclasheun self-assigned this Feb 9, 2025
@niclasheun niclasheun linked an issue Feb 9, 2025 that may be closed by this pull request
Application Mailing Settings buttons are inactive for unknown reason #113
Closed
Mtze
Mtze requested changes Feb 11, 2025
View reviewed changes
Copy link
Member

@Mtze Mtze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested this PR on our test server and noticed that the tooltip on the "manual send" buttons is still misleading. They are inactive because the mail has no subject or body but the tooltip shows to check the course mail settings.

@Mtze Mtze added the Component: Core Issues related to the prompt core label Feb 14, 2025
Mtze
Mtze approved these changes Feb 14, 2025
View reviewed changes
Copy link
Member

@Mtze Mtze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now works as expected

@niclasheun niclasheun merged commit 701252c into main Feb 14, 2025
24 checks passed
@niclasheun niclasheun deleted the mailing-settings-improvements branch February 14, 2025 21:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mtze Mtze Mtze approved these changes

Assignees

@niclasheun niclasheun

Labels
Component: Core Issues related to the prompt core
Projects
PROMPT
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Application Mailing Settings buttons are inactive for unknown reason
2 participants
@niclasheun @Mtze