updates to align more with DM style guide #155
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
humnaawan
force-pushed
the
tickets/SP-1696
branch
from
14e104c to
8760cea
Compare
rhiannonlynne
requested changes
Feb 20, 2025
| @@ -566,7 +566,7 @@ def _check_feasibility(self, conditions): | |||
| distances = _angular_separation( | |||
| self.ra, self.dec, self.ra[max_reward_indx], self.dec[max_reward_indx] | |||
| ) | |||
| valid_pix = np.where((np.isnan(reward) == False) & (distances < self.max_radius_peak))[0] | |||
| valid_pix = np.where((np.isnan(reward) is False) & (distances < self.max_radius_peak))[0] | |||
There was a problem hiding this comment.
"is" can't be used in this comparison
| @@ -213,7 +213,7 @@ def flush_script(self, conditions): | |||
| """Remove things from the script that aren't needed anymore""" | |||
| if self.obs_wanted is not None: | |||
| still_relevant = np.where( | |||
| (self.obs_wanted["observed"] == False) & (self.obs_wanted["flush_by_mjd"] > conditions.mjd) | |||
| (self.obs_wanted["observed"] is False) & (self.obs_wanted["flush_by_mjd"] > conditions.mjd) | |||
humnaawan
force-pushed
the
tickets/SP-1696
branch
from
8760cea to
a34e1f1
Compare
|
@rhiannonlynne I replaced the two instances of the not-element-wise checks - please lmk what you think. also, would you know how to fix the CI check with the docs? |
humnaawan
force-pushed
the
tickets/SP-1696
branch
from
a34e1f1 to
2f56654
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.