Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DM-45748: Add shellcheck and Markdownlint #19

Merged
merged 1 commit into from
Aug 13, 2024
Merged

DM-45748: Add shellcheck and Markdownlint #19

merged 1 commit into from
Aug 13, 2024

Conversation

roceb
Copy link
Contributor

@roceb roceb commented Aug 13, 2024

No description provided.

@roceb roceb force-pushed the tickets/DM-45748 branch 3 times, most recently from d6fae7f to f774836 Compare August 13, 2024 17:38
Copy link
Member

@timj timj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine. The Jira ticket doesn't tell me why we need this though? I assume you have multiple repos that repeat this check code but it would be helpful if the Jira ticket explained this.

@roceb roceb force-pushed the tickets/DM-45748 branch from f774836 to 80e7c64 Compare August 13, 2024 18:11
@roceb roceb merged commit 7253fbb into main Aug 13, 2024
3 checks passed
@roceb roceb deleted the tickets/DM-45748 branch August 13, 2024 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants