Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add FastAPI tutorial #3

Draft
wants to merge 36 commits into
base: main
Choose a base branch
from
Draft

Add FastAPI tutorial #3

wants to merge 36 commits into from

Conversation

luabud
Copy link
Owner

@luabud luabud commented Oct 14, 2023

The content of the tutorial is in the docs/python/tutorial-fastapi.md file.

Luiz-N and others added 5 commits October 17, 2023 08:38
* Adding formatter table

* adding changes

* Update docs/python/formatting.md

Co-authored-by: Karthik Nadig <[email protected]>

* Update docs/python/formatting.md

* Update docs/python/formatting.md

Co-authored-by: Luciana Abud <[email protected]>

* Adding import sorting extensions table

* Adding setup instructions for import sorting

* typo

* fixing more typos

* On save sentence

* adding workspace settings

---------

Co-authored-by: Karthik Nadig <[email protected]>
Co-authored-by: Luciana Abud <[email protected]>
Co-authored-by: Courtney Webster <[email protected]>
docs/python/tutorial-fastapi.md Outdated Show resolved Hide resolved
docs/python/tutorial-fastapi.md Outdated Show resolved Hide resolved
docs/python/tutorial-fastapi.md Outdated Show resolved Hide resolved
docs/python/tutorial-fastapi.md Outdated Show resolved Hide resolved
docs/python/tutorial-fastapi.md Outdated Show resolved Hide resolved
docs/python/tutorial-fastapi.md Outdated Show resolved Hide resolved
docs/python/tutorial-fastapi.md Outdated Show resolved Hide resolved
docs/python/tutorial-fastapi.md Outdated Show resolved Hide resolved
docs/python/tutorial-fastapi.md Outdated Show resolved Hide resolved
docs/python/tutorial-fastapi.md Outdated Show resolved Hide resolved
docs/python/tutorial-fastapi.md Outdated Show resolved Hide resolved
```
And replace it with:
```python
item_id = redis_client.hget("item_name_to_id", item.item_name)
Copy link

@debonte debonte Oct 21, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The amount of red squiggles that showed up after this change made me uncomfortable. I wonder if there's a more incremental approach we could take to these changes?

docs/python/tutorial-fastapi.md Outdated Show resolved Hide resolved
docs/python/tutorial-fastapi.md Outdated Show resolved Hide resolved
docs/python/tutorial-fastapi.md Outdated Show resolved Hide resolved
docs/python/tutorial-fastapi.md Outdated Show resolved Hide resolved
docs/python/tutorial-fastapi.md Outdated Show resolved Hide resolved
* Add browser version info

* feedback
docs/python/tutorial-fastapi.md Outdated Show resolved Hide resolved
docs/python/tutorial-fastapi.md Outdated Show resolved Hide resolved
docs/python/tutorial-fastapi.md Outdated Show resolved Hide resolved
docs/python/tutorial-fastapi.md Outdated Show resolved Hide resolved
docs/python/tutorial-fastapi.md Outdated Show resolved Hide resolved
docs/python/tutorial-fastapi.md Outdated Show resolved Hide resolved
docs/python/tutorial-fastapi.md Show resolved Hide resolved
docs/python/tutorial-fastapi.md Show resolved Hide resolved
docs/python/tutorial-fastapi.md Show resolved Hide resolved
docs/python/tutorial-fastapi.md Show resolved Hide resolved
@luabud
Copy link
Owner Author

luabud commented Oct 24, 2023

Can't thank @debonte and @cwebster-99 enough for all the feedback! I think I solved the biggest problems in this PR so I'll open it on the docs repo to get more eyes on it: https://github.com/microsoft/vscode-docs/pull/6760/files. If you find more things that can be improved please feel free to keep adding comments, it's been extremely helpful!

luabud and others added 8 commits October 24, 2023 19:20
* scaffold new Custom Layout topic

* Locked editor group basics

Part of microsoft#6568

* add a couple of images

* Add Panel alignment section and image

* Add more sections

* Locked editor groups

* Add pinned tab image

* avoid a line break

---------

Co-authored-by: Daniel Imms <[email protected]>
Co-authored-by: Daniel Imms <[email protected]>
Co-authored-by: Courtney Webster <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants