-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add FastAPI tutorial #3
base: main
Are you sure you want to change the base?
Conversation
* Adding formatter table * adding changes * Update docs/python/formatting.md Co-authored-by: Karthik Nadig <[email protected]> * Update docs/python/formatting.md * Update docs/python/formatting.md Co-authored-by: Luciana Abud <[email protected]> * Adding import sorting extensions table * Adding setup instructions for import sorting * typo * fixing more typos * On save sentence * adding workspace settings --------- Co-authored-by: Karthik Nadig <[email protected]> Co-authored-by: Luciana Abud <[email protected]>
Co-authored-by: Courtney Webster <[email protected]>
docs/python/tutorial-fastapi.md
Outdated
``` | ||
And replace it with: | ||
```python | ||
item_id = redis_client.hget("item_name_to_id", item.item_name) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The amount of red squiggles that showed up after this change made me uncomfortable. I wonder if there's a more incremental approach we could take to these changes?
Co-authored-by: Erik De Bonte <[email protected]>
Co-authored-by: Erik De Bonte <[email protected]>
* Add browser version info * feedback
Co-authored-by: Erik De Bonte <[email protected]>
Can't thank @debonte and @cwebster-99 enough for all the feedback! I think I solved the biggest problems in this PR so I'll open it on the docs repo to get more eyes on it: https://github.com/microsoft/vscode-docs/pull/6760/files. If you find more things that can be improved please feel free to keep adding comments, it's been extremely helpful! |
* scaffold new Custom Layout topic * Locked editor group basics Part of microsoft#6568 * add a couple of images * Add Panel alignment section and image * Add more sections * Locked editor groups * Add pinned tab image * avoid a line break --------- Co-authored-by: Daniel Imms <[email protected]>
Co-authored-by: Daniel Imms <[email protected]> Co-authored-by: Courtney Webster <[email protected]>
Co-authored-by: Brigit Murtaugh <[email protected]>
The content of the tutorial is in the
docs/python/tutorial-fastapi.md
file.