Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(icons): added mount-fuji icon #2717

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

jstoxrocky
Copy link

@jstoxrocky jstoxrocky commented Jan 4, 2025

What is the purpose of this pull request?

  • New Icon

Description

Added new mount-fuji icon.

Icon use case

Tourism and Travel Platforms: Use it to highlight hotels, tours, or properties with views of Mount Fuji or activities like hiking around the area.
Japanese Cultural or Regional Categorization: Represents Japan and can be used for anything Japanese-related, like properties, attractions, or regions tied to Mount Fuji.

Alternative icon designs

Icon Design Checklist

Concept

  • I have provided valid use cases for each icon.
  • I have not added any a brand or logo icon.
  • I have not used any hate symbols.
  • I have not included any religious or political imagery.

Author, credits & license

  • The icons are solely my own creation.
  • The icons were originally created in # by @
  • I've based them on the following Lucide icons:
  • I've based them on the following design:

Naming

  • I've read and followed the naming conventions
  • I've named icons by what they are rather than their use case.
  • I've provided meta JSON files in icons/[iconName].json.

Design

  • I've read and followed the icon design guidelines
  • I've made sure that the icons look sharp on low DPI displays.
  • I've made sure that the icons look consistent with the icon set in size, optical volume and density.
  • I've made sure that the icons are visually centered.
  • I've correctly optimized all icons to three points of precision.

Before Submitting

@github-actions github-actions bot added 🎨 icon About new icons 🫧 metadata Improved metadata labels Jan 4, 2025
Copy link

github-actions bot commented Jan 4, 2025

Added or changed icons

icons/mount-fuji.svg

Preview cohesion icons/square-activity.svg
icons/mount-fuji.svg
icons/arrow-big-left.svg
Preview stroke widths icons/mount-fuji.svg
icons/mount-fuji.svg
icons/mount-fuji.svg
DPI Preview (24px) icons/mount-fuji.svg
Icon X-rays icons/mount-fuji.svg
Icon Diffs icons/mount-fuji.svg
Icons as code

Works for: lucide-react, lucide-react-native, lucide-preact, lucide-vue-next

const MountFujiIcon = createLucideIcon('MountFuji', [
  ["path",{"d":"M 10 9 L 13.5 6"}],
  ["path",{"d":"M 13.5 6 L 18 9"}],
  ["path",{"d":"M 16 3 L 22 21"}],
  ["path",{"d":"M 2 21 L 8 3"}],
  ["path",{"d":"M 22 21 L 2 21"}],
  ["path",{"d":"M 7 6 L 10 9"}],
  ["path",{"d":"M 8 3 L 16 3"}],
  ["path",{"d":"M 8 3 L 8 3"}]
])

Comment on lines 12 to 14
<path d="M15.5 4C18 3 15 2 12 2S6 3 8.5 4c1 1 6 1 7 0" />
<path d="m18 14-5-2.5-3 2L7.5 11" />
<path d="M22 22 15 8H9L2 22z" />
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The use case doesn't feel very strong, but putting that aside, this has multiple guideline violations.

I also feel like it should be closer to https://lucide.dev/icons/mountain-snow

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated the svg to be closer to mountain-snow. Also updated the use cases.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🎨 icon About new icons 🫧 metadata Improved metadata
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants