-
-
Notifications
You must be signed in to change notification settings - Fork 564
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(icons): added kominka
icon
#2720
base: main
Are you sure you want to change the base?
Conversation
Added or changed iconsIcons as codeWorks for: const RyokanIcon = createLucideIcon('Ryokan', [
["path",{"d":"M 10 6 L 10 10"}],
["path",{"d":"M 12 16 L 12 21"}],
["path",{"d":"M 12 3 Q 19 7 21 5"}],
["path",{"d":"M 14 6 L 14 10"}],
["path",{"d":"M 16 16 L 16 21"}],
["path",{"d":"M 17 6 L 17 10"}],
["path",{"d":"M 19 14 L 19 21"}],
["path",{"d":"M 19 21 L 5 21"}],
["path",{"d":"M 21 13 Q 19 14 18 10"}],
["path",{"d":"M 3 13 L 21 13"}],
["path",{"d":"M 3 13 Q 5 14 6 10"}],
["path",{"d":"M 3 5 Q 5 7 12 3"}],
["path",{"d":"M 5 21 L 5 14"}],
["path",{"d":"M 6 10 L 18 10"}],
["path",{"d":"M 6 6 L 18 6"}],
["path",{"d":"M 7 10 L 7 6"}],
["path",{"d":"M 8 16 L 16 16"}],
["path",{"d":"M 8 16 L 8 21"}]
]) |
2px gap rule! |
@jguddas Do I not have a 2px gap? I used Lucide Studio to create...Looks like to 2px gap to me unless I'm not seeing something you're seeing. Is negative space supposed to be 2px? I see a 2px gap rule between distinct elements but I don't think that applies to a house...or does it? |
@jguddas Are you referencing the density rule? I read these designs but not exactly sure which 2px rule I violate. The distinct object rule? I thought of the house as 1 distinct object... |
A-ha, but it's not distinct objects, but distinct elements; as in the roof, the door, various decorative lines etc. You can think of this rule as all distinct gaps should be able to fit a circle of 2px diameter, which is very much not the case here. |
Or as in, if you scale up the stroke width to 3px there should be no new points on any lines that touch each other. |
What is the purpose of this pull request?
Description
Added new
kominka
icon.Icon use case
Traditional Japanese Properties: Perfect for representing listings of kominka (traditional Japanese houses) or ryokan (Japanese-style inns) on real estate or travel websites, helping users quickly identify these culturally unique accommodations.
Cultural Tourism: Use it on travel platforms to highlight stays or experiences tied to traditional Japanese architecture, like ryokan bookings, hot spring getaways, or historical property tours.
Alternative icon designs
Icon Design Checklist
Concept
Author, credits & license
Naming
icons/[iconName].json
.Design
Before Submitting