Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(icons): added kominka icon #2720

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

jstoxrocky
Copy link

What is the purpose of this pull request?

  • New Icon

Description

Added new kominka icon.

Icon use case

Traditional Japanese Properties: Perfect for representing listings of kominka (traditional Japanese houses) or ryokan (Japanese-style inns) on real estate or travel websites, helping users quickly identify these culturally unique accommodations.

Cultural Tourism: Use it on travel platforms to highlight stays or experiences tied to traditional Japanese architecture, like ryokan bookings, hot spring getaways, or historical property tours.

Alternative icon designs

Icon Design Checklist

Concept

  • I have provided valid use cases for each icon.
  • I have not added any a brand or logo icon.
  • I have not used any hate symbols.
  • I have not included any religious or political imagery.

Author, credits & license

  • The icons are solely my own creation.
  • The icons were originally created in # by @
  • I've based them on the following Lucide icons:
  • I've based them on the following design:

Naming

  • I've read and followed the naming conventions
  • I've named icons by what they are rather than their use case.
  • I've provided meta JSON files in icons/[iconName].json.

Design

  • I've read and followed the icon design guidelines
  • I've made sure that the icons look sharp on low DPI displays.
  • I've made sure that the icons look consistent with the icon set in size, optical volume and density.
  • I've made sure that the icons are visually centered.
  • I've correctly optimized all icons to three points of precision.

Before Submitting

@github-actions github-actions bot added 🎨 icon About new icons 🫧 metadata Improved metadata labels Jan 6, 2025
Copy link

github-actions bot commented Jan 6, 2025

Added or changed icons

icons/ryokan.svg

Preview cohesion icons/square-pilcrow.svg
icons/ryokan.svg
icons/pencil-line.svg
Preview stroke widths icons/ryokan.svg
icons/ryokan.svg
icons/ryokan.svg
DPI Preview (24px) icons/ryokan.svg
Icon X-rays icons/ryokan.svg
Icon Diffs icons/ryokan.svg
Icons as code

Works for: lucide-react, lucide-react-native, lucide-preact, lucide-vue-next

const RyokanIcon = createLucideIcon('Ryokan', [
  ["path",{"d":"M 10 6 L 10 10"}],
  ["path",{"d":"M 12 16 L 12 21"}],
  ["path",{"d":"M 12 3 Q 19 7 21 5"}],
  ["path",{"d":"M 14 6 L 14 10"}],
  ["path",{"d":"M 16 16 L 16 21"}],
  ["path",{"d":"M 17 6 L 17 10"}],
  ["path",{"d":"M 19 14 L 19 21"}],
  ["path",{"d":"M 19 21 L 5 21"}],
  ["path",{"d":"M 21 13 Q 19 14 18 10"}],
  ["path",{"d":"M 3 13 L 21 13"}],
  ["path",{"d":"M 3 13 Q 5 14 6 10"}],
  ["path",{"d":"M 3 5 Q 5 7 12 3"}],
  ["path",{"d":"M 5 21 L 5 14"}],
  ["path",{"d":"M 6 10 L 18 10"}],
  ["path",{"d":"M 6 6 L 18 6"}],
  ["path",{"d":"M 7 10 L 7 6"}],
  ["path",{"d":"M 8 16 L 16 16"}],
  ["path",{"d":"M 8 16 L 8 21"}]
])

@jguddas
Copy link
Member

jguddas commented Jan 6, 2025

2px gap rule!

@jstoxrocky
Copy link
Author

2px gap rule!

@jguddas Do I not have a 2px gap? I used Lucide Studio to create...Looks like to 2px gap to me unless I'm not seeing something you're seeing. Is negative space supposed to be 2px? I see a 2px gap rule between distinct elements but I don't think that applies to a house...or does it?

Screenshot 2025-01-06 at 7 16 46 PM

@jguddas
Copy link
Member

jguddas commented Jan 6, 2025

@jstoxrocky
Copy link
Author

https://lucide.dev/guide/design/icon-design-guide

@jguddas Are you referencing the density rule? I read these designs but not exactly sure which 2px rule I violate. The distinct object rule? I thought of the house as 1 distinct object...

Screenshot 2025-01-06 at 7 45 54 PM

@karsa-mistmere
Copy link
Member

https://lucide.dev/guide/design/icon-design-guide

@jguddas Are you referencing the density rule? I read these designs but not exactly sure which 2px rule I violate. The distinct object rule? I thought of the house as 1 distinct object...

A-ha, but it's not distinct objects, but distinct elements; as in the roof, the door, various decorative lines etc.

You can think of this rule as all distinct gaps should be able to fit a circle of 2px diameter, which is very much not the case here.

@jguddas
Copy link
Member

jguddas commented Jan 7, 2025

Or as in, if you scale up the stroke width to 3px there should be no new points on any lines that touch each other.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🎨 icon About new icons 🫧 metadata Improved metadata
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants