Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/Upload multiple files in different fields #1541

Merged
merged 3 commits into from
Jan 28, 2024

Conversation

jackey8616
Copy link
Collaborator

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Have you written unit tests?
  • Have you written unit tests that cover the negative cases (i.e.: if bad data is submitted, does the library respond properly)?
  • This PR is associated with an existing issue?

Closing issues
Closes #1493
Put closes #XXXX (where XXXX is the issue number) in your comment to auto-close the issue that your PR fixes.

If this is a new feature submission:

  • Has the issue had a maintainer respond to the issue and clarify that the feature is something that aligns with the goals and philosophy of the project?

Potential Problems With The Approach
n/a

Test plan
Tested with unit test with multiple decorator usage.

Copy link
Collaborator

@WoH WoH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a question about existing coverage

packages/cli/src/routeGeneration/templates/express.hbs Outdated Show resolved Hide resolved
@jackey8616
Copy link
Collaborator Author

@WoH This PR is also good to go. thx

@WoH
Copy link
Collaborator

WoH commented Jan 28, 2024

Can you please rebase?

@jackey8616
Copy link
Collaborator Author

Can you please rebase?

Rebase completed.

@WoH WoH merged commit 0731169 into lukeautry:master Jan 28, 2024
18 checks passed
@jackey8616 jackey8616 deleted the feat/1493 branch January 28, 2024 23:24
@yyoshiki41
Copy link

Thank you for your ongoing development efforts!
Could you inform me when the npm package will be released?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upload multiple files with different field names
3 participants