Mike21 Driver

[JanCaha]

Driver for Mike21 format: https://www.xmswiki.com/wiki/SMS:MIKE_21_*.mesh.

Currently there is some code duplication with 2DM format, which could be eliminated by making functions _parse_vertex_id_gaps() and _persist_native_index() part of MDAL API. Also the class that extends MemoryMesh to store vertexIDs that might not be continuous could be generalized and shared by Mike21 and 2DM format.

[PeterPetrik]

looks good

[PeterPetrik]

_parse_vertex_id_gaps() and _persist_native_index() part of MDAL API

definitely not to MDAL API, if you want to can add it to mdal_utils , but it is not necessary

[JanCaha]

Fix the issues, you mentioned @PeterPetrik . Also realized that there are few more validations that can be done on the file, so I added them + tests.

[JanCaha]

There was an issue where the new driver was trying to load another format, due to too simple canReadMesh(). Now better checks are performed to ensure that the Mike21 file can be read prior to reading. Which avoids the issue.

[PeterPetrik]

looks good; @JanCaha you need to add new driver to

• https://github.com/lutraconsulting/MDAL/tree/master/docs/source/drivers
• https://github.com/lutraconsulting/MDAL/blob/master/README.md

[vcloarec]

is it necessary to use this new derived class ? I don't see in the code where the methods of this class are used.

[JanCaha]

This just copies the approach used in 2DM driver and it should allow the use of the mesh structure later. No direct use for those fuctions right now. But for 2DM driver it is rather similar, those functions are only used in ASCII_DAT format.

[PeterPetrik]

I think it is fine... easier to understand it is in-Memory?

[JanCaha]

Yes