Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

XMDF fixes #492

Merged
merged 24 commits into from
Nov 6, 2024
Merged

XMDF fixes #492

merged 24 commits into from
Nov 6, 2024

Conversation

JanCaha
Copy link
Contributor

@JanCaha JanCaha commented Oct 30, 2024

This PR contains two fixes for XMDF format:

  • first is properly reading MESH datasets from H5 file with more complex structure in the file
  • second part is loading the MESH frame from H5 file if is stored as 2DMeshModule format

uclaros
uclaros reviewed Nov 6, 2024
View reviewed changes
Copy link
Contributor

@uclaros uclaros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!
Some minor comments

mdal/frmts/mdal_xmdf.cpp Outdated Show resolved Hide resolved
mdal/frmts/mdal_xmdf.cpp Outdated Show resolved Hide resolved
mdal/frmts/mdal_xmdf.cpp Show resolved Hide resolved
mdal/frmts/mdal_xmdf.cpp Outdated Show resolved Hide resolved
@JanCaha JanCaha merged commit e781a53 into master Nov 6, 2024
14 of 15 checks passed
@uclaros uclaros deleted the xmdf-fixes branch November 8, 2024 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@uclaros uclaros uclaros approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JanCaha @uclaros