-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add tests #23
Conversation
…ral tests and skips
☂️ Python Coverage
Overall Coverage
New FilesNo new covered files... Modified FilesNo covered modified files...
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@HonzaCuhel thanks a lot for the tests. @tersekmatija, should we set some kind of test coverage threshold for future PRs?
BTW, I don't see check results for this PR. @HonzaCuhel are they skipped? |
They weren't skipped, but for some reason, there are not visible now. So I'm linking here the results: I had to set some skipping rules for HW requirements for most of the tests, since a lot of them were failing on the standard GH runners. Here are the specs of the standard GH runners, which are for free. The biggest issue is the disk size, there's only 14GB, which is just not enough for all the models and the dependencies, therefore I wasn't even able to run the unittests for image generation. Apparently, there are also GH large runners that are only available for organizations and enterprises using the GitHub Team or GitHub Enterprise Cloud plans (link). Or we could run the tests on our device. |
@tersekmatija @kozlov721 Your thoughts on running resource-intensive tests? |
This PR includes: