Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests #23

Merged
merged 25 commits into from
Jan 15, 2024
Merged

Add tests #23

merged 25 commits into from
Jan 15, 2024

Conversation

HonzaCuhel
Copy link
Contributor

This PR includes:

  • unit tests for used components
  • integration tests for the whole pipeline
  • workflow for automatic testing when creating PRs

@luxonis luxonis deleted a comment from github-actions bot Jan 13, 2024
Copy link

☂️ Python Coverage

current status: ✅

Overall Coverage

Lines Covered Coverage Threshold Status
686 301 44% 0% 🟢

New Files

No new covered files...

Modified Files

No covered modified files...

updated for commit: 453a5aa by action🐍

Copy link
Member

@sokovninn sokovninn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@HonzaCuhel thanks a lot for the tests. @tersekmatija, should we set some kind of test coverage threshold for future PRs?

@sokovninn
Copy link
Member

BTW, I don't see check results for this PR. @HonzaCuhel are they skipped?

@HonzaCuhel
Copy link
Contributor Author

HonzaCuhel commented Jan 15, 2024

BTW, I don't see check results for this PR. @HonzaCuhel are they skipped?

They weren't skipped, but for some reason, there are not visible now. So I'm linking here the results:

  • the pre-commit check link
  • the actual tests link

I had to set some skipping rules for HW requirements for most of the tests, since a lot of them were failing on the standard GH runners. Here are the specs of the standard GH runners, which are for free. The biggest issue is the disk size, there's only 14GB, which is just not enough for all the models and the dependencies, therefore I wasn't even able to run the unittests for image generation.
image

Apparently, there are also GH large runners that are only available for organizations and enterprises using the GitHub Team or GitHub Enterprise Cloud plans (link). Or we could run the tests on our device.

@sokovninn
Copy link
Member

@tersekmatija @kozlov721 Your thoughts on running resource-intensive tests?

@sokovninn sokovninn merged commit 43d6c65 into dev Jan 15, 2024
@sokovninn sokovninn deleted the add-tests branch January 18, 2024 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants