-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/batched prompt generation #33
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
☂️ Python Coverage
Overall Coverage
New FilesNo new covered files... Modified Files
|
Test Results 6 files 6 suites 44m 23s ⏱️ Results for commit a0ae403. |
HonzaCuhel
approved these changes
Feb 16, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
sokovninn
added a commit
that referenced
this pull request
Mar 2, 2024
* feature: add batched prompt generation * feature: add --batch_size_prompt argument * test: add simple argument test * feature: add batched prompt generation speed measuring * refactor: remove redundant print * fix: change default batch_size_prompt to 64 * style: black formatting * refactor: typo
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
batch_size_prompt
is set to 64 (TinyLlama and Mistral-4bit should fit into an 8GB GPU).generate_prompt()
function withgenerate_prompts_batch()
.Output of the script
datadreamer/examples/measure_batched_prompt_gen_speed.py
:(batch_size x time_per_prompt) - maximal batch size for each model that fits into an NVIDIA L4 24GB GPU.
TinyLlama looks like the best choice. Mistral-Int4 should be used only if GPU memory is less than 16GB.