Feature/luxonis loader dataset #57
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
☂️ Python Coverage
Overall Coverage
New FilesNo new covered files... Modified Files
|
HonzaCuhel
approved these changes
Jul 29, 2024
There was a problem hiding this comment.
LGTM!
@sokovninn, I noticed there's no unittest for LuxonisDatasetConverter. Is it possible to locally test it somehow that it works?
conorsim
reviewed
Jul 29, 2024
| image_batches = LOADERS_REGISTRY.get(args.loader_plugin)( | ||
| view="all", dataset_id=args.dataset_id | ||
| ) | ||
| print(len(image_batches)) |
There was a problem hiding this comment.
Maybe leftover print statement?
| print(len(image_batches)) | ||
| else: | ||
| raise ValueError( | ||
| "GOOGLE_APPLICATION_CREDENTIALS environment variable is not set for using the loader plugin" |
There was a problem hiding this comment.
I suppose you could have a loader plugin which does not rely on GOOGLE_APPLICATION_CREDENTIALS
…uxonis/datadreamer into feature/luxonis-loader-dataset
Test Results 6 files 6 suites 38m 2s ⏱️ Results for commit 4ac588f. |
…uxonis/datadreamer into feature/luxonis-loader-dataset
…uxonis/datadreamer into feature/luxonis-loader-dataset
conorsim
approved these changes
Aug 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes: