Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Style changes #9

Merged
merged 15 commits into from
Dec 11, 2023
Merged

Style changes #9

merged 15 commits into from
Dec 11, 2023

Conversation

kozlov721
Copy link
Contributor

Style changes

  • Updated pre-commit to be the same as in models
  • Made a few small changes in pyproject.toml
    • Added settings for tools used in pre-commit
    • Package versions
    • Dev requirements
    • GH action to regenerate requirements.txt from pyproject.toml on change
  • Formatting
  • Fixed few unambiguous linter issues
    • @sokovninn please take a look at the remaining issues and fix so the pre-commit action passes
  • Small changes to README
    • TOC
    • Links
    • License badge

tersekmatija
tersekmatija approved these changes Dec 11, 2023
View reviewed changes
Copy link
Collaborator

@tersekmatija tersekmatija left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Let's make sure the tests pass and then merge.

sokovninn
sokovninn approved these changes Dec 11, 2023
View reviewed changes
Copy link
Member

@sokovninn sokovninn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Issues fixed. Thanks @kozlov721 for valuable improvements.

conorsim
conorsim approved these changes Dec 11, 2023
View reviewed changes
Copy link
Collaborator

@conorsim conorsim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@sokovninn sokovninn merged commit 1a86b5e into main Dec 11, 2023
2 checks passed
@sokovninn sokovninn deleted the package_changes branch December 12, 2023 11:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@conorsim conorsim conorsim approved these changes

@tersekmatija tersekmatija tersekmatija approved these changes

@sokovninn sokovninn sokovninn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@kozlov721 @sokovninn @tersekmatija @conorsim @actions-user