-
Notifications
You must be signed in to change notification settings - Fork 132
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Updated FW with productName as protected field and ImageManip behavio…
…r revert
- Loading branch information
Showing
3 changed files
with
5 additions
and
1 deletion.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7f284dc
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any reason why
productName
also become protected? I am currently relying on it to inject keywordFFC
to enable CAM_D port.7f284dc
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It started to represent a device name / part name and useful to match against in case needed (eg:
OAK-D-LITE
orOAK-D
, ...)@chengguizi what kind of a device are you using at the moment? We'll expose such things through
BoardConfig
- let us know (feel free to open an issue for it)7f284dc
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@themarpe I am currently using OAK-SoM-Pro modules. Some of them do not come with a meaningful Board Name (some come with wrong one in fact). So I have to rely on configurable Product name to make sure port support is proper.
I am happy to open an issue on this, if needed!
7f284dc
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@chengguizi do you mind sharing output of this som by using the calibration dump script? Bare soms should not come pre-flashed out of factory. If a field is empty you should be able to flash it even if its protected.
7f284dc
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@themarpe I agree that most som comes with empty boardNames and productNames. But I do have a few units come with filled boardNames. I am not sure if I accidently falshed them with other .json files from off-the-shelf product like OAK-D.
Anyway, for such cases, I currently have no means on 2.19.1 version to change boardName and productName. Is there a way to force it? Or perhaps allow me to clear the names.
Otherwise, i can stick to old versions, just for flashing productName task. Inconvenience though.
7f284dc
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is a way to force, though unpreferred. Might rather rely on older version for such specific operation.
I assume those units were flashed later on. The main issues is that we cannot ONLY rely on USER area of EEPROM as some older devices do not come with FACTORY yet flashed.
Though we could allow complete flashing of USER area (including protected fields) if FACTORY was present... TBD, but would have to be paired with factory flashed SoMs in this case