-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update ImgExtractedDetection: Soften confidence check #166
Conversation
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #166 +/- ##
==========================================
+ Coverage 35.88% 36.54% +0.66%
==========================================
Files 70 74 +4
Lines 4013 4085 +72
==========================================
+ Hits 1440 1493 +53
- Misses 2573 2592 +19 ☔ View full report in Codecov by Sentry. |
What's the use case of conf. values being higher than 1? |
The reason behind this is, so that when the model is quantized or the values are just badly rounded, the DAI script won't crash. Which is exactly what happened when I tested YOLOv7 tiny inference on a RVC4 device. The parser returned the following confidences scores: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there anywhere else we have a similar issue that we could handle inside this PR CC: @sokovninn @aljazkonec1
Can we rather clip the values to be between 0 and 1? EDIT: Yeah I see Klemen already said that |
|
Let's also include same checks and clips there inside this PR as well then. |
This PR softens the confidence check in
ImgDetectionExtended
class, so that values like1.0000001192092896
would pass.