Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests: Docker support. #167

Merged
merged 5 commits into from
Jan 30, 2025
Merged

Tests: Docker support. #167

merged 5 commits into from
Jan 30, 2025

Conversation

kkeroo
Copy link
Collaborator

@kkeroo kkeroo commented Jan 28, 2025

This PR moves HIL execution to docker.

We have two images in our registry: one for e2e tests and one for integration tests. Image is pulled on the testbed itself. The tests run in the docker container completely. We are technically not limited anymore on specific testbeds but still we have some limitations because all testbeds do not include fully-pipeline-ready devices.

To add in the future:

  • join the both images into a single one and optimize its size.

@github-actions github-actions bot added the tests Changes affecting tests label Jan 28, 2025
@codecov-commenter
Copy link

codecov-commenter commented Jan 28, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 35.89%. Comparing base (b013402) to head (f42d71a).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #167      +/-   ##
==========================================
+ Coverage   35.88%   35.89%   +0.01%     
==========================================
  Files          70       70              
  Lines        4013     4014       +1     
==========================================
+ Hits         1440     1441       +1     
  Misses       2573     2573              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@klemen1999 klemen1999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, let's wait for tests to get picked up and pass. After we should clean up the commented code.
Do we also want to update the e2e workflow?

@kkeroo
Copy link
Collaborator Author

kkeroo commented Jan 28, 2025

Yeah, I will clean up the code this is first attempt with workflow from the repo. I just want to make sure it works and passes. Then I will also push E2E changes - I have them locally.

Copy link
Collaborator

@klemen1999 klemen1999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@klemen1999 klemen1999 merged commit 6cce15b into main Jan 30, 2025
11 checks passed
@klemen1999 klemen1999 deleted the tests/docker branch January 30, 2025 11:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tests Changes affecting tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants