-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tests: Docker support. #167
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #167 +/- ##
==========================================
+ Coverage 35.88% 35.89% +0.01%
==========================================
Files 70 70
Lines 4013 4014 +1
==========================================
+ Hits 1440 1441 +1
Misses 2573 2573 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, let's wait for tests to get picked up and pass. After we should clean up the commented code.
Do we also want to update the e2e workflow?
Yeah, I will clean up the code this is first attempt with workflow from the repo. I just want to make sure it works and passes. Then I will also push E2E changes - I have them locally. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This PR moves HIL execution to docker.
We have two images in our registry: one for e2e tests and one for integration tests. Image is pulled on the testbed itself. The tests run in the docker container completely. We are technically not limited anymore on specific testbeds but still we have some limitations because all testbeds do not include fully-pipeline-ready devices.
To add in the future: