Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Added new rule in config auto-population and updated documentation. #140

Merged
merged 5 commits into from
Dec 5, 2024

Conversation

JSabadin
Copy link
Contributor

@JSabadin JSabadin commented Dec 4, 2024

Update: Configuration Smart Auto-population, Docs

This PR updates the documentation to include the trainer.smart_cfg_auto_populate flag and its auto-population rules.

Key Changes:

  1. Docs Update:
    • Added details for the smart_cfg_auto_populate flag and its rules.
  2. New Rule:
    • If train_view, val_view, and test_view are the same, and n_validation_batches is not set, it defaults to 10 to prevent validation/testing on the entire training set.
  3. Predefined Detection Configs:
    • Added a training strategy to the predefined detection configurations and updated the documentation for the detection light model

@JSabadin JSabadin requested a review from a team as a code owner December 4, 2024 13:13
@JSabadin JSabadin requested review from kozlov721, klemen1999, tersekmatija and conorsim and removed request for a team December 4, 2024 13:13
@github-actions github-actions bot added documentation Improvements or additions to documentation enhancement New feature or request labels Dec 4, 2024
Copy link
Collaborator

@klemen1999 klemen1999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

configs/README.md Show resolved Hide resolved
Copy link

codecov bot commented Dec 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.98%. Comparing base (631b905) to head (bc3b847).
Report is 20 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #140      +/-   ##
==========================================
- Coverage   96.31%   95.98%   -0.34%     
==========================================
  Files         147      168      +21     
  Lines        6304     7322    +1018     
==========================================
+ Hits         6072     7028     +956     
- Misses        232      294      +62     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@klemen1999 klemen1999 merged commit 8be019f into main Dec 5, 2024
8 of 9 checks passed
@klemen1999 klemen1999 deleted the feat/n-validation-batches-autopopulate branch December 5, 2024 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants