Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated weights loading for DDRNet #148

Merged
merged 1 commit into from
Jan 5, 2025
Merged

Updated weights loading for DDRNet #148

merged 1 commit into from
Jan 5, 2025

Conversation

klemen1999
Copy link
Collaborator

  • Updated path for light and heavy predefined segmentation model weights
  • Improved how we load DDRNet head weights, previous ones weren't actually taken into account because of wrong values in the state dict

@klemen1999 klemen1999 requested a review from a team as a code owner January 3, 2025 09:36
@klemen1999 klemen1999 requested review from kozlov721, tersekmatija and conorsim and removed request for a team January 3, 2025 09:36
@github-actions github-actions bot added the fix Fixing a bug label Jan 3, 2025
Copy link

codecov bot commented Jan 3, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.01%. Comparing base (631b905) to head (07e9c2c).
Report is 26 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #148      +/-   ##
==========================================
- Coverage   96.31%   95.01%   -1.31%     
==========================================
  Files         147      170      +23     
  Lines        6304     7523    +1219     
==========================================
+ Hits         6072     7148    +1076     
- Misses        232      375     +143     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@kozlov721 kozlov721 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@klemen1999 klemen1999 merged commit 6076408 into main Jan 5, 2025
8 of 9 checks passed
@klemen1999 klemen1999 deleted the fix/ddrnet_weights branch January 5, 2025 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix Fixing a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants