Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed extra params when creating archive #149

Merged
merged 3 commits into from
Jan 7, 2025

Conversation

klemen1999
Copy link
Collaborator

Removed deprecated reverse_channels adn interleaved_to_planar parameters when creating an NNArchive. Instead dai_type is now used.

@klemen1999 klemen1999 requested a review from a team as a code owner January 6, 2025 17:29
@klemen1999 klemen1999 requested review from kozlov721, tersekmatija and conorsim and removed request for a team January 6, 2025 17:29
@github-actions github-actions bot added the fix Fixing a bug label Jan 6, 2025
Copy link

codecov bot commented Jan 6, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.01%. Comparing base (631b905) to head (baf8a8a).
Report is 28 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #149      +/-   ##
==========================================
- Coverage   96.31%   95.01%   -1.31%     
==========================================
  Files         147      170      +23     
  Lines        6304     7526    +1222     
==========================================
+ Hits         6072     7151    +1079     
- Misses        232      375     +143     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@klemen1999 klemen1999 merged commit 31aeb39 into main Jan 7, 2025
8 of 9 checks passed
@klemen1999 klemen1999 deleted the fix/archive_extra_params branch January 7, 2025 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix Fixing a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants