Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Task Label Groups Support #22

Merged
merged 8 commits into from
Apr 24, 2024
Merged

Task Label Groups Support #22

merged 8 commits into from
Apr 24, 2024

Conversation

kozlov721
Copy link
Collaborator

Added support for task label groups as implemented in luxonis-ml in 101.

@kozlov721 kozlov721 added the enhancement New feature or request label Apr 21, 2024
@kozlov721 kozlov721 self-assigned this Apr 21, 2024
Copy link

github-actions bot commented Apr 21, 2024

Test Results

  6 files    6 suites   1h 5m 7s ⏱️
 57 tests  57 ✅ 0 💤 0 ❌
342 runs  342 ✅ 0 💤 0 ❌

Results for commit 5f6f0db.

♻️ This comment has been updated with latest results.

Copy link

☂️ Python Coverage

current status: ✅

Overall Coverage

Lines Covered Coverage Threshold Status
4686 3765 80% 0% 🟢

New Files

No new covered files...

Modified Files

File Coverage Status
luxonis_train/models/luxonis_model.py 89% 🟢
luxonis_train/utils/boxutils.py 83% 🟢
luxonis_train/utils/config.py 95% 🟢
luxonis_train/utils/loaders/base_loader.py 60% 🟢
luxonis_train/utils/loaders/luxonis_loader_torch.py 100% 🟢
luxonis_train/utils/types.py 94% 🟢
TOTAL 87% 🟢

updated for commit: 5f6f0db by action🐍

Copy link
Collaborator

@conorsim conorsim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Leaving comments for now in case multi-task support is still needed

luxonis_train/models/luxonis_model.py Outdated Show resolved Hide resolved
@@ -425,7 +426,8 @@ def anchors_from_dataset(

widths = []
inputs = None
for inp, labels in loader:
for inp, task_labels in loader:
labels = next(iter(task_labels.values())) # TODO: handle multiple tasks
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

# TODO: handle multiple tasks

What is needed for this TODO?

@kozlov721 kozlov721 merged commit ca57063 into dev Apr 24, 2024
5 of 8 checks passed
@kozlov721 kozlov721 deleted the feature/dataset-task-groups branch April 24, 2024 00:07
kozlov721 added a commit that referenced this pull request Oct 9, 2024
* handling SIGTERM signal

* resume argument takes path

* basic task group labels support

* updated requirements

* fixed tests

* fixed loader test

* Update luxonis_train/models/luxonis_model.py

Co-authored-by: conorsim <[email protected]>

---------

Co-authored-by: conorsim <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants