Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New Keypoint Heads and Losses #40

Merged
merged 49 commits into from
Jul 11, 2024
Merged

New Keypoint Heads and Losses #40

merged 49 commits into from
Jul 11, 2024

Conversation

JSabadin
Copy link
Contributor

  • Added sigma and area factor to the metrics.

  • The implicit keypoint bbox head now uses a new OKC loss instead of the detection loss.

  • Added a new Efficient keypoint bbox head and loss.

  • Updates to README:

    • Instructions for luxonis-train inspect and evaluate commands.
    • Description of the new head and loss.
    • Updated weight names for the implicit keypoint bbox loss.

JSabadin and others added 30 commits May 23, 2024 09:44
@JSabadin
Fix keypoint and bbox losses and update boxutils
2ec21ca
@klemen1999
some refactoring regarding sigmas and area factor
348d27a
@JSabadin
Changed the prepare, _create_keypoint_target, match_to_anchor to wor…
89eb327 
…k with visibility
@JSabadin
Changed the prepare, _create_keypoint_target, match_to_anchor to wor…
8f59dd1 
…k with visibility
@klemen1999
fixed merge conflict
373d3e0
@JSabadin
Removed OKC compute due to some inconsistencies between the loss form…
e4f31e7 
…ula and OKC computation.
@JSabadin
Resolved merge conflicts
47d57d7
@JSabadin
Visual refinement
450096a
@JSabadin
to device
0169990
@JSabadin
Added new EfficientKeypointBbox head and loss. Attempted to fix the k…
f7b09b8 
…eypoint loss.
@JSabadin
Fixed input parameters for NMS
f63cb1e
@JSabadin
fixed a bug in the loss function
3d75f6e
@JSabadin
removed print statements
4ef7714
@JSabadin
Changed unsupported ONNX operations
0a1c1cd
@JSabadin
Changed rank 3 operations to rank 4 operations in export
cda1410
@JSabadin
atempt to fix the high loss
2a4a2c9
@JSabadin
Apply pre-commit fixes
6e8a33a
@klemen1999
added sigmas and area_factor to metrics
8dec23a
@JSabadin
Incorporated specific changes from feature/efficientrep-variants into…
bb69250 
… fix/kps-head-loss
@JSabadin
Merge branch 'fix/kps-head-loss' of https://github.com/luxonis/luxoni…
540348e 
…s-train into fix/kps-head-loss
@JSabadin
Fix regression loss bug
27efc09
@JSabadin
Fixed visualizer bug that skipped the first keypoint and fixed loss
b0764b7
@JSabadin
multiplied area with 0.53 in the loss
cdf6305
@JSabadin
multiplied area with 0.53 in the loss
8433ab3
@JSabadin
fixed a bug in keypoints preprocess
6f911d9
@JSabadin
Removed redundant bbox conversion and removed area_factor from loss
492612e
@JSabadin
Added erea_factor back to loss
db1fcec
@JSabadin
fix bbox format
64ccfaa
@JSabadin
Added postprocessing to export
3385c97
@JSabadin
Proper export
8a31223
kozlov721
kozlov721 reviewed Jun 13, 2024
View reviewed changes
Copy link
Collaborator

@kozlov721 kozlov721 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a few minor comments, mostly related to types. Otherwise LGTM!

@JSabadin
Copy link
Contributor Author

I have fixed the type annotations and function renamings as @kozlov721 proposed.

@kozlov721
Copy link
Collaborator

I have fixed the type annotations and function renamings as @kozlov721 proposed.

Thanks. Also please update the tests (assigner tests) so the checks pass. They should all pass now; I temporarily disabled the MacOS tests.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 14, 2024 •
edited
Loading

☂️ Python Coverage

current status: ✅

Overall Coverage

Lines Covered Coverage Threshold Status
5185 3866 75% 0% 🟢

New Files

File Coverage Status
luxonis_train/attached_modules/losses/efficient_keypoint_bbox_loss.py 24% 🟢
luxonis_train/nodes/efficient_keypoint_bbox_head.py 19% 🟢
TOTAL 22% 🟢

Modified Files

File Coverage Status
luxonis_train/attached_modules/losses/init.py 100% 🟢
luxonis_train/attached_modules/losses/adaptive_detection_loss.py 98% 🟢
luxonis_train/attached_modules/losses/implicit_keypoint_bbox_loss.py 97% 🟢
luxonis_train/attached_modules/losses/keypoint_loss.py 97% 🟢
luxonis_train/attached_modules/metrics/mean_average_precision.py 100% 🟢
luxonis_train/attached_modules/metrics/mean_average_precision_keypoints.py 95% 🟢
luxonis_train/attached_modules/metrics/object_keypoint_similarity.py 87% 🟢
luxonis_train/attached_modules/visualizers/keypoint_visualizer.py 100% 🟢
luxonis_train/core/archiver.py 18% 🟢
luxonis_train/nodes/init.py 100% 🟢
luxonis_train/nodes/efficient_bbox_head.py 100% 🟢
luxonis_train/nodes/enums/head_categorization.py 100% 🟢
luxonis_train/utils/assigners/atts_assigner.py 98% 🟢
luxonis_train/utils/assigners/tal_assigner.py 97% 🟢
luxonis_train/utils/boxutils.py 83% 🟢
TOTAL 91% 🟢

updated for commit: ce5ed26 by action🐍

@tersekmatija tersekmatija requested a review from kozlov721 June 17, 2024 10:34
kozlov721
kozlov721 approved these changes Jun 17, 2024
View reviewed changes
Copy link
Collaborator

@kozlov721 kozlov721 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

conorsim
conorsim approved these changes Jun 18, 2024
View reviewed changes
Copy link
Collaborator

@conorsim conorsim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm lacking domain knowledge but from a quick look it looks good

@kozlov721 kozlov721 added the enhancement New feature or request label Jun 21, 2024
@kozlov721 kozlov721 changed the title Add new keypoints head and substitute implicit keypoint bbox detection loss with OKC loss New Keypoint Heads and Losses Jun 21, 2024
@kozlov721 kozlov721 merged commit 57258ee into dev Jul 11, 2024
8 checks passed
@kozlov721 kozlov721 deleted the fix/kps-head-loss branch July 11, 2024 16:41
@kozlov721 kozlov721 mentioned this pull request Oct 9, 2024
Merged
kozlov721 added a commit that referenced this pull request Oct 9, 2024
@JSabadin @klemen1999
@kozlov721 @actions-user
New Keypoint Heads and Losses (#40)
fccdc96 
Co-authored-by: klemen1999 <[email protected]>
Co-authored-by: Martin Kozlovsky <[email protected]>
Co-authored-by: GitHub Actions <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kozlov721 kozlov721 kozlov721 approved these changes

@conorsim conorsim conorsim approved these changes

@tersekmatija tersekmatija Awaiting requested review from tersekmatija

Assignees

@JSabadin JSabadin

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@JSabadin @kozlov721 @conorsim @klemen1999 @actions-user