Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Miscellaneous Fixes and Features #55

Merged
merged 10 commits into from
Aug 12, 2024
Merged

Miscellaneous Fixes and Features #55

merged 10 commits into from
Aug 12, 2024

Conversation

kozlov721
Copy link
Collaborator

  • Added tests for a complex custom multi-task network
  • Fixes and missing features discovered by the tests
    • Fixed reading n_keypoints from the dataset
    • Automatic selection of correct task parameter for TorchMetric based metrics ("binary" or "multiclass")
  • Few small style related changes

@kozlov721 kozlov721 added enhancement New feature or request fix Fixing a bug tests Adding or changing tests labels Aug 12, 2024
@kozlov721 kozlov721 self-assigned this Aug 12, 2024
@github-actions GitHub Actions
Copy link

Test Results

2 files  2 suites   27s ⏱️
1 tests 0 ✅ 0 💤 0 ❌ 1 🔥
2 runs  0 ✅ 0 💤 0 ❌ 2 🔥

For more details on these errors, see this check.

Results for commit b1dde45.

klemen1999
klemen1999 approved these changes Aug 12, 2024
View reviewed changes
Copy link
Collaborator

@klemen1999 klemen1999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kozlov721 kozlov721 merged commit c116982 into dev Aug 12, 2024
3 of 8 checks passed
@kozlov721 kozlov721 deleted the tests/integration branch August 12, 2024 23:38
kozlov721 added a commit that referenced this pull request Oct 9, 2024
@kozlov721
Miscellaneous Fixes and Features (#55)
fc95771
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@klemen1999 klemen1999 klemen1999 approved these changes

@tersekmatija tersekmatija Awaiting requested review from tersekmatija

@conorsim conorsim Awaiting requested review from conorsim

Assignees

@kozlov721 kozlov721

Labels
enhancement New feature or request fix Fixing a bug tests Adding or changing tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kozlov721 @klemen1999