-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unified Cores and Cleanup #57
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kozlov721
added
enhancement
New feature or request
tests
Adding or changing tests
labels
Aug 15, 2024
Test Results 3 files 3 suites 32m 45s ⏱️ For more details on these failures, see this check. Results for commit 491bf0d. ♻️ This comment has been updated with latest results. |
klemen1999
approved these changes
Aug 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unified all
Core
subclasses intoLuxonisModel
luxonis_train.core.Core
renamed toLuxonisModel
luxonis_train.models.LuxonisModel
renamed toLuxonisLightningModule
Trainer
,Inferer
,Exporter
etc., there is onlyLuxonisModel
Before:
This would create the following directories:
Now:
Miscellaneous
luxonis_ml.nodes.blocks
luxonis_ml
instead of defining them againBaseLoader.input_shape
toBaseLoader.input_shapes
upload_to_run
option toexporter
andtracker
configuration sectionsTrue
by default