Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug1276 use libcurl instead of libsoup #1398

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

rich-coe
Copy link
Contributor

Attempt to resolve lost connections from libsoup using libcurl.
Missing proxy support.

@lwindolf
Copy link
Owner

lwindolf commented Jan 1, 2025

@rich-coe Sorry for not reacting!

I'm mostly concerned about the testing, so I'd say this should not go into 1.15/1.16. What do you think? Or would you say libsoup3 is too unstable for a 1.16.0 release? In my daily usage I see rare bugs, but there are almost invisible overall.

So if at all I'd tend to switch the networking together with the Gtk4 port, which needs a lot of testing anyway.

@lwindolf
Copy link
Owner

lwindolf commented Jan 1, 2025

Don't worry about any merge conflicts. They are not hard to resolve :-)

@rich-coe
Copy link
Contributor Author

rich-coe commented Jan 1, 2025

@lwindolf
I don't have any issues waiting for the GTK-4 integration.
The only two issues I know of are (1) determining if the proxy is configured and fetching the configuration info for the proxy, and (2) not marking the feed 'in error' on the UI when some feeds return a non-success code for no update since last referesh.

@rich-coe
Copy link
Contributor Author

rich-coe commented Jan 1, 2025

for (1) proxy config, the code currently fetches the proxy info. I'll have to setup the proxy config and test that it works.
for (2) I'll debug the feed that this happens on.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants