incusd/network/bridge: Fix deletion of tunnels and dummy devices #1627
+72
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous code relied purely on the name of the device to decide if a device should be deleted which was not correct and could result in the deletion of unwanted devices. The new code ensures that the device is part of the bridge and that its kind is correct before deleting it. Signed-off-by: montag451 <[email protected]>
montag451
force-pushed
the
bridge-tun-deletion
branch
from
0dfcb9f to
b3e65e9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous code relied purely on the name of the device to decide if a device should be deleted which was not correct and could result in the deletion of unwanted devices. The new code ensures that the device is part of the bridge and that its kind is correct before deleting it.