add timer to key GET paths #431
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meng-han
commented
Aug 20, 2024
| @@ -86,48 +86,49 @@ def get_credential_list(): | |||
| :statuscode 200: Success | |||
| :statuscode 403: Client does not have permissions to list credentials. | |||
| """ | |||
There was a problem hiding this comment.
it's interesting how git detects the diff: the only changes made is add with stats.timer( and added indent to following lines
alejandroroiz
approved these changes
Aug 20, 2024
meng-han
added a commit
that referenced
this pull request
Aug 21, 2024
Follow up to #431, add more detailed timers breakdown to see which one is the worst contributors
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Was wondering what caused frontend to be so slow? did an analysis on UI and ranked captured network calls by timer. The slow and popular APIs are get and list services/credentials. Emitting stats to understand how slow it is and follow up on action items