Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add log debug headers + config testing #217

Open
wants to merge 40 commits into
base: master
Choose a base branch
from
Open
Changes from 2 commits
Commits
Show all changes
40 commits
Select commit Hold shift + click to select a range
6718de0
add log debug headers
anuvedverma Jul 1, 2024
28bde1d
use error log level
anuvedverma Jul 1, 2024
2773cf3
add logging for error response header
anuvedverma Jul 1, 2024
8bc1af9
other config changes
riteshvaryani Jul 2, 2024
c4e3200
config testing
riteshvaryani Jul 2, 2024
d1ad10a
test
riteshvaryani Jul 2, 2024
365e481
add more changes
riteshvaryani Jul 2, 2024
57e0995
more config changes
riteshvaryani Jul 2, 2024
3eb9da8
add logging for error request/response header size
anuvedverma Jul 2, 2024
7bd21d9
add logging for success at 1%
anuvedverma Jul 2, 2024
e781b3f
remove full header debug from success
anuvedverma Jul 2, 2024
fba8a40
more updates
riteshvaryani Jul 2, 2024
603ff4d
fix
anuvedverma Jul 2, 2024
c17fbf7
fix style
anuvedverma Jul 2, 2024
ccde25e
add check for header not just content size
anuvedverma Jul 2, 2024
a3eb319
Update ProxyHandler.java
riteshvaryani Jul 2, 2024
8f72c71
dropwizard update
riteshvaryani Jul 2, 2024
68d4cf9
Merge branch 'sev-16337-add-header-logging' of github.com:lyft/presto…
riteshvaryani Jul 2, 2024
f488a04
compile fix
riteshvaryani Jul 2, 2024
60db65e
more fixes
riteshvaryani Jul 2, 2024
7092cdb
lint fixes
riteshvaryani Jul 2, 2024
fd6b9f6
fix header logging
anuvedverma Jul 2, 2024
765f61d
Update ProxyHandler.java
riteshvaryani Jul 2, 2024
b145513
Update ProxyHandler.java
riteshvaryani Jul 2, 2024
1ce2104
add logging in preconnection hook
anuvedverma Jul 2, 2024
80ac96c
checkstyle fixes
anuvedverma Jul 2, 2024
5911d0b
adding error counters
jchoi614 Jul 2, 2024
4d1c079
forgot to uncomment
jchoi614 Jul 2, 2024
29613c4
fix checkstyle
jchoi614 Jul 2, 2024
d9cfe8d
update dropwizard ver
jchoi614 Jul 2, 2024
0fee702
updating dropwizard dependency
jchoi614 Jul 2, 2024
94ed9d8
update
riteshvaryani Jul 3, 2024
2cb6d66
pom changes
riteshvaryani Jul 3, 2024
1c25d75
try request logging
riteshvaryani Jul 3, 2024
76f038b
add handler
riteshvaryani Jul 3, 2024
7d60671
add stats handler
anuvedverma Jul 3, 2024
2cd95fe
add StatsHandler jetty logs
anuvedverma Jul 3, 2024
6343539
Merge pull request #218 from lyft/add-stats-handler
anuvedverma Jul 3, 2024
a2303ac
fix debug log
anuvedverma Jul 3, 2024
c772828
shutdown scheduler thread on close
anuvedverma Jul 3, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -66,10 +66,20 @@ protected void postConnectionHook(
log.error("Exception occurred while processing request URL: {} , request URI {} ,"
+ " servlet path {} , toString {}", request.getRequestURL(),
request.getRequestURI(), request.getServletPath(), request.toString(), var9);
errorLogHeaders(request);
riteshvaryani marked this conversation as resolved.
Show resolved Hide resolved
callback.failed(var9);
}
}

protected void errorLogHeaders(HttpServletRequest request) {
log.error("-------HttpServletRequest headers---------");
riteshvaryani marked this conversation as resolved.
Show resolved Hide resolved
Enumeration<String> headers = request.getHeaderNames();
while (headers.hasMoreElements()) {
String header = headers.nextElement();
log.error(header + "->" + request.getHeader(header));
}
}

protected void debugLogHeaders(HttpServletRequest request) {
if (log.isDebugEnabled()) {
log.debug("-------HttpServletRequest headers---------");
Expand Down
Loading