Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consistent console config; README examples #23

Merged
merged 2 commits into from
Jul 9, 2024
Merged

Consistent console config; README examples #23

merged 2 commits into from
Jul 9, 2024

Conversation

kspurgin
Copy link
Contributor

@kspurgin kspurgin commented Jul 9, 2024

  • Make bin/console use the same config as running a CLI command would
  • Update custom config examples in README to include the staff segment in the base_uri

kspurgin added 2 commits July 9, 2024 12:16
@kspurgin
Make console use same config as CLI
cbb5e3b
@kspurgin
Add staff before api in custom config examples
ffae230 
As I was informed yesterday that "API is usually at
whatever.url/staff/api", I thought the examples should reflect that.
@kspurgin kspurgin requested a review from mark-cooper July 9, 2024 16:27
@mark-cooper
Copy link
Member

@kspurgin looks good to me.

Re: base_uri there's no requirement for staff to be part of the path to the api. For development it would typically be http://localhost:4567. But I have no issue with updating the example.

@mark-cooper mark-cooper merged commit f7905e2 into master Jul 9, 2024
1 check passed
@mark-cooper mark-cooper deleted the console-config branch July 9, 2024 22:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mark-cooper mark-cooper Awaiting requested review from mark-cooper

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kspurgin @mark-cooper