Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX error AttributeError: '_Certificate' object has no attribute 'not… #58

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

FIX error AttributeError: '_Certificate' object has no attribute 'not… #58

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions requests_pkcs12.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,8 +34,9 @@
from ssl import PROTOCOL_SSLv23 as default_ssl_protocol

def _check_cert_not_after(cert):
cert_not_after = cert.not_valid_after_utc
if cert_not_after < datetime.datetime.now(datetime.timezone.utc):
cert_not_after = cert.not_valid_after
#if cert_not_after < datetime.datetime.now(datetime.timezone.utc):
if cert_not_after.replace(tzinfo=datetime.timezone.utc) < datetime.datetime.now(datetime.timezone.utc):
raise ValueError('Client certificate expired: Not After: {cert_not_after:%Y-%m-%d %H:%M:%SZ}'.format(**locals()))

def _create_sslcontext(pkcs12_data, pkcs12_password_bytes, ssl_protocol):
Expand Down