add optional SSL support
#46
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Needs documentation (docstring update). |
|
Many things missing, e.g.
|
|
You could do the protocols one by one if you prefer, and then we merge those PRs to a separate branch first. |
fsagbuya
force-pushed
the
ssl-support
branch
2 times, most recently
from
98e30d6 to
2bdae90
Compare
|
This doesn't authenticate the client, does it? |
|
I think you can add a client certificate (with different SSL API calls), or just a password. |
fsagbuya
force-pushed
the
ssl-support
branch
2 times, most recently
from
12ac4f4 to
2a7f45f
Compare
fsagbuya
force-pushed
the
ssl-support
branch
from
2a7f45f to
4e1e835
Compare
fsagbuya
force-pushed
the
ssl-support
branch
from
4e1e835 to
ea5c140
Compare
fsagbuya
force-pushed
the
ssl-support
branch
2 times, most recently
from
be0b423 to
717b7ca
Compare
fsagbuya
force-pushed
the
ssl-support
branch
2 times, most recently
from
df2093b to
58e7e1d
Compare
fsagbuya
force-pushed
the
ssl-support
branch
from
58e7e1d to
c0aed03
Compare
thomasfire
reviewed
Jan 14, 2025
Signed-off-by: Florian Agbuya <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add optional SSL/TLS support with mutual authentication. SSL is enabled when certificate files are provided.
AsyncioServerrequiring both server and client certificatesClient,AsyncioClient, andBestEffortClientclasses to support mutual SSL authenticationsimple_server_loopto handle certificate verificationsipyco_rpctool(--cert, --key, --cafile)Related issue:
m-labs/artiq#2577