Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[buildkite] Migrate buildkite pipeline from AWS to GCP #4273

Merged
merged 5 commits into from
Jun 25, 2024

Conversation

kentzeng12
Copy link
Collaborator

@kentzeng12 kentzeng12 commented Jun 22, 2024

What this PR does / why we need it:
Our buildkite pipeline uses AWS queues and is broken. We are switching over to use GCP queues to fix this. This PR only adds basic unit tests to the pipeline. Further work is needed to fix the remaining steps in our broken pipeline. Having basic unit tests is good enough for now to unblock pending PRs on our repo.

Special notes for your reviewer:

Does this PR introduce a user-facing and/or backwards incompatible change?:
No

Does this PR require updating code package or user-facing documentation?:
No

@kentzeng12 kentzeng12 changed the title [buildkite] Migrate pipeline to GCP and make unit tests pass [buildkite] Migrate buildkite pipeline from AWS to GCP Jun 22, 2024
@kentzeng12 kentzeng12 force-pushed the zengk/gcp_migration branch 22 times, most recently from 3fc39a0 to 6d0ac88 Compare June 24, 2024 06:46
@kentzeng12 kentzeng12 force-pushed the zengk/gcp_migration branch from 6d0ac88 to 5e85fdb Compare June 24, 2024 06:48
Copy link
Contributor

@andrewmains12 andrewmains12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add that comment block but otherwise lgtm!

@kentzeng12 kentzeng12 merged commit a068ec8 into master Jun 25, 2024
5 checks passed
@kentzeng12 kentzeng12 deleted the zengk/gcp_migration branch June 25, 2024 16:05
@kentzeng12 kentzeng12 linked an issue Jun 25, 2024 that may be closed by this pull request
kentzeng12 added a commit that referenced this pull request Jun 25, 2024
* Migrate buildkite pipeline from aws to gcp

* Add common block to unit test step

* Add kubernetes plugin to Codegen step

* Make unit test pass in pipeline

* Make unit test pass in pipeline
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Buildkite pipeline is broken
2 participants