-
Notifications
You must be signed in to change notification settings - Fork 455
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[buildkite] Fix "Prometheus compatibility (:docker:)" test in buildkite pipeline #4295
Merged
Merged
Changes from 92 commits
Commits
Show all changes
93 commits
Select commit
Hold shift + click to select a range
301446f
comment out other tests
kentzeng12 3e0fe68
add make to dockerfile
kentzeng12 ea440fb
remove make, and add kubernetes plugin
kentzeng12 9f722d7
add docker-compose
kentzeng12 c4c6b12
add docker-compose to dockerfile
kentzeng12 c67f91d
update m3query volumes in docker-compose
kentzeng12 d922e6c
comment out trap defer EXIT command in run.sh
kentzeng12 c10fd72
uncomment previous code
kentzeng12 fc865d8
experimenting with commenting out rest of run.sh
kentzeng12 66e7dc7
comment out everything except for line 51 and 52 at the end of run.sh
kentzeng12 52281cf
uncomment lines 53-69
kentzeng12 c907f2a
uncomment lines 71-75
kentzeng12 ead72c2
comment out lines 71 to 75 and uncomment go test in run.sh
kentzeng12 055b09a
check if prometheus container is running
kentzeng12 40dd69d
adding logs to check prometheus container not running
kentzeng12 d016524
update volume mount for prometheus in docker-compose
kentzeng12 dff9a73
modify right hand side of volume mount for prometheus in docker-compose
kentzeng12 6ada8c5
try another volume mount for prometheus
kentzeng12 b91746f
remove volume mounts to see what happens in docker-compose
kentzeng12 b9ea790
add back logs in docker-setup
kentzeng12 fc8e967
try adding prometheusURL to run.sh
kentzeng12 4790b1e
change localhost to host.docker.internal
kentzeng12 31f1737
check for firewall
kentzeng12 af547b8
add sudo to dockerfile
kentzeng12 12c6f20
add ufw to dockerfile
kentzeng12 63956f4
inspect prometheus docker container for network issues
kentzeng12 c7e5209
modify docker inspect command
kentzeng12 5d0d90d
add back volume mount for prometheus
kentzeng12 71d5c5d
fix typo in volume mount
kentzeng12 099edb8
fix another typo in volume mount for prometheus
kentzeng12 dc39fcc
find the current directory to fix volume mount
kentzeng12 cb173ac
update volume mount for prometheus with new directory
kentzeng12 033e0fd
fix typo
kentzeng12 9b10e0c
rewrite volume mount
kentzeng12 7257065
list out contents in host machine
kentzeng12 74650d9
move ls, and pwd
kentzeng12 38cb15d
use absolute path for volume mount
kentzeng12 6814f39
add volume mount for m3query
kentzeng12 91c406d
update m3query volume mount
kentzeng12 43da619
update volume mount again for prometheus
kentzeng12 aba59e2
another volume mount configuration
kentzeng12 5575430
another volume mount configuration
kentzeng12 10520cd
try another way to volume mount
kentzeng12 3a3fd3b
add m3query.yml
kentzeng12 a70f7d9
add external:true
kentzeng12 94a1a56
try using quotes
kentzeng12 014c46d
remove volume mount for m3query
kentzeng12 faf9a34
add docker inspect for m3query
kentzeng12 a7bb0ab
try adding another app
kentzeng12 076044d
change to localhost
kentzeng12 121cb62
use external to create volume mounts
kentzeng12 ca242de
add pwd to see why we can't find run.sh
kentzeng12 6230a00
try another volume mount
kentzeng12 cb5b41b
use host docker internal
kentzeng12 5c5dbe5
add host.docker.internal to queryaddress
kentzeng12 69d9dc7
did we get here?
kentzeng12 475b747
add logging for response body
kentzeng12 d2bdff2
test
kentzeng12 ca574ac
update volume mount for m3query
kentzeng12 ab8fe4e
add slash to volume mount
kentzeng12 4b0174f
comment out volume mount to see what happens
kentzeng12 ab35f11
try deleting random CMD in m3comparator
kentzeng12 5dd2f18
add m3comparator
kentzeng12 6eb180f
add logs to see promResult and queryResult
kentzeng12 3d0751b
don't use deprecated readall
kentzeng12 37155fd
add log for querygroups
kentzeng12 bc23d99
remove fetch querygroup
kentzeng12 6448287
add back fetch query group
kentzeng12 d93e50f
change comparator_write
kentzeng12 bd1225f
add log to find endpoint
kentzeng12 05db6e2
only log the promResult
kentzeng12 77ead0d
only log the prometheus result actually
kentzeng12 c338de8
log queries
kentzeng12 a9a6819
switch to using ioutil, and remove some logs
kentzeng12 0302873
test revert back to localhost:9000 for m3query-dev-remote
kentzeng12 5fbef1d
revert back to m3comparator:9000, else we get 500 error
kentzeng12 640eb7e
revert back to localhost for comparator in run.sh to test
kentzeng12 1f0f2cd
revert promAddress to 0.0.0.0 to test
kentzeng12 2b8907f
add back volume mount to m3query container
kentzeng12 562715c
update volume mount for m3query
kentzeng12 62fae3f
change promAddress to queryAddress
kentzeng12 85b2354
add comparator address
kentzeng12 1aeba01
change to m3comparator:9001
kentzeng12 a9b9396
change to host.docker.internal instead of m3comparator
kentzeng12 721609e
uncomment last command in run.sh
kentzeng12 7e135a2
change test to host.docker.internal
kentzeng12 afb11c6
change m3query to host.docker.internal
kentzeng12 0777c6e
uncomment rest of pipeline tests
kentzeng12 943d190
comment out documentation tests
kentzeng12 4d5c8c0
add back CMD in m3comparator.dockerfile
kentzeng12 28a8364
add space in dockerfile
kentzeng12 31f1846
remove logs and clean up temp code
kentzeng12 7bb9923
Merge branch 'master' into zengk/prometheus
kentzeng12 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +1,3 @@ | ||
FROM golang:1.22-bullseye | ||
|
||
RUN apt-get update && apt-get install -y lsof netcat-openbsd docker.io jq | ||
RUN apt-get update && apt-get install -y lsof netcat-openbsd docker.io jq docker-compose |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kentzeng12 is this only called from a docker context? (afaict answer is yes, so this is okay).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since it's being run in the buildkite, which runs the test in a docker container, yes it's called in a docker context, but like you mentioned if you run this locally we run into issues.