Initial Commit #1
Conversation
| @@ -0,0 +1,15 @@ | |||
| language: go | |||
There was a problem hiding this comment.
Not something we have to solve with this PR but I wonder if we should templatize this file somehow so we don't have to change all of them each time we want to support different versions of Go for CI.
It could even be something like when running in CI it checks whether the versions of Go match the "master" version in some shared CI repo or something and fails the test run if it it's not up to date.
Let's forget doing anything for this repo, but wanted to bring it up. Let's find a way to solve this in the near future.
There was a problem hiding this comment.
Cool, opened m3db/ci-scripts#9 to track.
| @@ -0,0 +1,37 @@ | |||
| package: github.com/m3db/m3nsch | |||
There was a problem hiding this comment.
Can we add versions to all modules here to pin the modules? Just so we don't get random upgrades to packages unless we specify so. Pinning to at least a semver to avoid running glide update and getting a breaking change from packages not meant to be upgraded is important.
There was a problem hiding this comment.
For sure. I was under the impression that versions being mentioned in glide.lock was sufficient, will put them in glide.yaml too.
|
Changes Unknown when pulling 88708c0 on prateek/initial-commit into ** on master**. |
|
Changes Unknown when pulling 8387db8 on prateek/initial-commit into ** on master**. |
|
@r added licence in each file |
|
will open a subsequent pr to address the low coverage |
/cc @robskillington @xichen2020 @ben-lerner