Skip to content
This repository has been archived by the owner on Apr 8, 2019. It is now read-only.

Add more runtime.Memstats to reported metrics #183

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add more runtime.Memstats to reported metrics #183

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 20 additions & 11 deletions instrument/extended.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -126,17 +126,20 @@ func StartReportingExtendedMetrics(
}

type runtimeMetrics struct {
NumGoRoutines tally.Gauge
GoMaxProcs tally.Gauge
MemoryAllocated tally.Gauge
MemoryHeap tally.Gauge
MemoryHeapIdle tally.Gauge
MemoryHeapInuse tally.Gauge
MemoryStack tally.Gauge
GCCPUFraction tally.Gauge
NumGC tally.Counter
GcPauseMs tally.Timer
lastNumGC uint32
NumGoRoutines tally.Gauge
GoMaxProcs tally.Gauge
MemoryAllocated tally.Gauge
MemoryHeap tally.Gauge
MemoryHeapIdle tally.Gauge
MemoryHeapInuse tally.Gauge
MemoryHeapObjects tally.Gauge
MemoryStack tally.Gauge
GCCPUFraction tally.Gauge
NumGC tally.Counter
NextGC tally.Gauge
PointerLookups tally.Gauge
GcPauseMs tally.Timer
lastNumGC uint32
}

func (r *runtimeMetrics) report(metricsType ExtendedMetricsType) {
Expand All @@ -156,8 +159,11 @@ func (r *runtimeMetrics) report(metricsType ExtendedMetricsType) {
r.MemoryHeap.Update(float64(memStats.HeapAlloc))
r.MemoryHeapIdle.Update(float64(memStats.HeapIdle))
r.MemoryHeapInuse.Update(float64(memStats.HeapInuse))
r.MemoryHeapObjects.Update(float64(memStats.HeapObjects))
r.MemoryStack.Update(float64(memStats.StackInuse))
r.GCCPUFraction.Update(memStats.GCCPUFraction)
r.NextGC.Update(float64(memStats.NextGC))
r.PointerLookups.Update(float64(memStats.Lookups))

// memStats.NumGC is a perpetually incrementing counter (unless it wraps at 2^32).
num := memStats.NumGC
Expand Down Expand Up @@ -220,9 +226,12 @@ func NewExtendedMetricsReporter(
r.runtime.MemoryHeap = memoryScope.Gauge("heap")
r.runtime.MemoryHeapIdle = memoryScope.Gauge("heapidle")
r.runtime.MemoryHeapInuse = memoryScope.Gauge("heapinuse")
r.runtime.MemoryHeapObjects = memoryScope.Gauge("heapobjects")
r.runtime.MemoryStack = memoryScope.Gauge("stack")
r.runtime.GCCPUFraction = memoryScope.Gauge("gc-cpu-fraction")
r.runtime.NumGC = memoryScope.Counter("num-gc")
r.runtime.NextGC = memoryScope.Gauge("next-gc")
r.runtime.PointerLookups = memoryScope.Gauge("pointer-lookups")
r.runtime.GcPauseMs = memoryScope.Timer("gc-pause-ms")
r.runtime.lastNumGC = memstats.NumGC

Expand Down