Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check default value type of Parameter #405

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Check default value type of Parameter #405

wants to merge 1 commit into from

Conversation

kitagry
Copy link
Member

@kitagry kitagry commented Oct 27, 2024 •
edited
Loading

Check default value of parameter.

import luigi
import gokart
class MyTask(gokart.TaskOnKart):
    foo = luigi.IntParameter(default='s')  # Incompatible default for argument "foo" (default has type "str", argument has type "int")

hiro-o918
hiro-o918 approved these changes Oct 27, 2024
View reviewed changes
test/test_mypy.py
@@ -79,7 +79,6 @@ class MyEnum(enum.Enum):
FOO = enum.auto()

class MyTask(gokart.TaskOnKart):
# NOTE: mypy shows attr-defined error for the following lines, so we need to ignore it.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@hiro-o918
Copy link
Contributor

LGTM!!!!!

@hiro-o918
Copy link
Contributor

Oh, CI failed 😞

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hiro-o918 hiro-o918 hiro-o918 approved these changes

@hirosassa hirosassa Awaiting requested review from hirosassa

@yokomotod yokomotod Awaiting requested review from yokomotod

@Hi-king Hi-king Awaiting requested review from Hi-king

@ujiuji1259 ujiuji1259 Awaiting requested review from ujiuji1259

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kitagry @hiro-o918